Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2842793003: Clipboard Recent Content - Code Health - Move kAuthorizedScheme into Subclass (Closed)

Created:
3 years, 8 months ago by Mark P
Modified:
3 years, 7 months ago
Reviewers:
jif
CC:
chromium-reviews, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clipboard Recent Content - Code Health - Move kAuthorizedScheme into Subclass The variable and its related function is only used in one subclass, so it shouldn't sit in the base class and possibly mislead folks. BUG=711576 Review-Url: https://codereview.chromium.org/2842793003 Cr-Commit-Position: refs/heads/master@{#468626} Committed: https://chromium.googlesource.com/chromium/src/+/2fa356c2cb48d3383024a166cad38db369b99312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M components/open_from_clipboard/clipboard_recent_content.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_generic.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_generic.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Mark P
jif@, can you please take a look at this at your leisure? thanks, mark
3 years, 8 months ago (2017-04-25 21:44:51 UTC) #2
jif
lgtm
3 years, 7 months ago (2017-05-02 13:23:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842793003/1
3 years, 7 months ago (2017-05-02 13:24:00 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 14:11:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fa356c2cb48d3383024a166cad3...

Powered by Google App Engine
This is Rietveld 408576698