Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2842733002: [inspector] V8DebuggerAgent should not resume break in different group (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] V8DebuggerAgent should not resume break in different group - introduced pausedContextGroupId, - added targetContextGroupId param for V8Debugger::continueProgram method. BUG=chromium:714955 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2842733002 Cr-Commit-Position: refs/heads/master@{#44871} Committed: https://chromium.googlesource.com/v8/v8/+/f661fe84f4c3ded6370db988cfc0e6f659d59223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/inspector/v8-debugger.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/inspector/v8-debugger.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/inspector/debugger/pause.js View 1 chunk +5 lines, -1 line 0 comments Download
M test/inspector/debugger/pause-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kozy
Dmitry, please take a look!
3 years, 8 months ago (2017-04-25 02:19:16 UTC) #1
dgozman
Please describe what caused the problem in crbug issue, as I'm not sure how this ...
3 years, 8 months ago (2017-04-25 20:35:12 UTC) #2
dgozman
lgtm
3 years, 8 months ago (2017-04-25 21:02:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842733002/1
3 years, 8 months ago (2017-04-25 21:04:01 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 21:36:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f661fe84f4c3ded6370db988cfc0e6f659d...

Powered by Google App Engine
This is Rietveld 408576698