Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2842653006:
Enable test results presentation on instrumentation tests. (Closed)
|
Created:
3 years, 8 months ago by BigBossZhiling Modified:
3 years, 8 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable test results presentation on instrumentation tests.
Enable test results presentation on all instrumentation tests in
chromium.linux.json.
BUG=605572
Review-Url: https://codereview.chromium.org/2842653006
Cr-Commit-Position: refs/heads/master@{#467530}
Committed: https://chromium.googlesource.com/chromium/src/+/81773235f9e789fd6e5aacefcad70f1401b8c36e
Patch Set 1 #
Total comments: 2
Patch Set 2 : android webview #Messages
Total messages: 19 (8 generated)
Description was changed from ========== Enable test results presentation on instrumentation tests. Enable test results presentation on all instrumentation tests in chromium.linux.json. BUG=605572 ========== to ========== Enable test results presentation on instrumentation tests. Enable test results presentation on all instrumentation tests in chromium.linux.json. BUG=605572 ==========
hzl@google.com changed reviewers: + jbudorick@chromium.org
https://codereview.chromium.org/2842653006/diff/1/testing/buildbot/chromium.l... File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/2842653006/diff/1/testing/buildbot/chromium.l... testing/buildbot/chromium.linux.json:58: "test": "android_webview_test_apk" We should add it to all instances of android_webview_test_apk, too.
https://codereview.chromium.org/2842653006/diff/1/testing/buildbot/chromium.l... File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/2842653006/diff/1/testing/buildbot/chromium.l... testing/buildbot/chromium.linux.json:58: "test": "android_webview_test_apk" On 2017/04/26 00:42:06, jbudorick wrote: > We should add it to all instances of android_webview_test_apk, too. Done.
lgtm
The CQ bit was checked by hzl@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
hzl@google.com changed reviewers: + dpranke@chromium.org
Needs review from owner.
lgtm
The CQ bit was checked by hzl@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493249164667840,
"parent_rev": "60869ccf490d8a71bdbe64bca909b80b0348d805", "commit_rev":
"81773235f9e789fd6e5aacefcad70f1401b8c36e"}
Message was sent while issue was closed.
Description was changed from ========== Enable test results presentation on instrumentation tests. Enable test results presentation on all instrumentation tests in chromium.linux.json. BUG=605572 ========== to ========== Enable test results presentation on instrumentation tests. Enable test results presentation on all instrumentation tests in chromium.linux.json. BUG=605572 Review-Url: https://codereview.chromium.org/2842653006 Cr-Commit-Position: refs/heads/master@{#467530} Committed: https://chromium.googlesource.com/chromium/src/+/81773235f9e789fd6e5aacefcad7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/81773235f9e789fd6e5aacefcad7... |
