content/public/android/java/src/org/chromium/content_public/browser/WebContents.java - Issue 2842653004: Add back Rect parcelable to onSmartClipDataExtracted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Issue 2842653004: Add back Rect parcelable to onSmartClipDataExtracted. (Closed)

Patch Set: Avoid coordinate conversion Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java ('K') | « content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

diff --git a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

index 4f436b5e09870483f6b5ea3a2654b2a38c20fedb..782a1197f7d2c089137389100f0b3d6ae7fa3d91 100644

--- a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

+++ b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

@@ -4,6 +4,7 @@

package org.chromium.content_public.browser;

+import android.graphics.Rect;

import android.os.Handler;

import android.os.Parcelable;

@@ -324,7 +325,7 @@ public interface WebContents extends Parcelable {

* Initiate extraction of text, HTML, and other information for clipping puposes (smart clip)

* from the rectangle area defined by starting positions (x and y), and width and height.

- void requestSmartClipExtract(int x, int y, int width, int height);

+ void requestSmartClipExtract(Rect originalRect, int x, int y, int width, int height);

/**

* Register a handler to handle smart clip data once extraction is done.