Replace a stale fixme with a comment

Replace a stale fixme with a comment

Eliminate a stale FIXME comment in the SizesAttributeParser, and replaces it with a comment stating why sizes' media conditions should not be evaluated as non-screen media types.

BUG=357586
R=eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174206

[eseidel, 2014-05-16 17:59:35]

lgtm

[commit-bot: I haz the power, 2014-05-16 17:59:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoav@yoav.ws/284263005/1

[ojan, 2014-05-16 18:21:55]

https://codereview.chromium.org/284263005/diff/1/Source/core/css/parser/Sizes...
File Source/core/css/parser/SizesAttributeParser.cpp (right):

https://codereview.chromium.org/284263005/diff/1/Source/core/css/parser/Sizes...
Source/core/css/parser/SizesAttributeParser.cpp:76: // A Media Condition cannot
have a media type other then screen.
Can you make this an ASSERT instead of a comment?

[cbiesinger, 2014-05-16 18:25:44]

https://codereview.chromium.org/284263005/diff/1/Source/core/css/parser/Sizes...
File Source/core/css/parser/SizesAttributeParser.cpp (right):

https://codereview.chromium.org/284263005/diff/1/Source/core/css/parser/Sizes...
Source/core/css/parser/SizesAttributeParser.cpp:76: // A Media Condition cannot
have a media type other then screen.
On 2014/05/16 18:21:56, ojan wrote:
> Can you make this an ASSERT instead of a comment?

The comment is just explaining why the next line always passes in "screen"

[commit-bot: I haz the power, 2014-05-16 19:19:36]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7637)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6949)

[commit-bot: I haz the power, 2014-05-16 20:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 20:21:15]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7650)

[cbiesinger, 2014-05-16 20:22:21]

On 2014/05/16 20:21:15, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_dbg on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7650)

This is ridiculous, I'll commit manually since it's just a comment change

[cbiesinger, 2014-05-16 20:23:59]

Committed patchset #1 manually as r174206 (presubmit successful).

[Yoav Weiss, 2014-05-17 14:14:54]

On 2014/05/16 18:25:44, cbiesinger wrote:
>
https://codereview.chromium.org/284263005/diff/1/Source/core/css/parser/Sizes...
> File Source/core/css/parser/SizesAttributeParser.cpp (right):
> 
>
https://codereview.chromium.org/284263005/diff/1/Source/core/css/parser/Sizes...
> Source/core/css/parser/SizesAttributeParser.cpp:76: // A Media Condition
cannot
> have a media type other then screen.
> On 2014/05/16 18:21:56, ojan wrote:
> > Can you make this an ASSERT instead of a comment?
> 
> The comment is just explaining why the next line always passes in "screen"

Yeah, what cbiesinger said. If the comment is not clear enough, I'd be happy to
change it to something clearer.