Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: Source/core/css/parser/SizesAttributeParser.cpp

Issue 284263005: Replace a stale fixme with a comment (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/SizesAttributeParser.cpp
diff --git a/Source/core/css/parser/SizesAttributeParser.cpp b/Source/core/css/parser/SizesAttributeParser.cpp
index d46afb0c345ac92e26fbee4f39931f967dd3349e..ce64693c241d448d72be1f288ee3d4bc33429e11 100644
--- a/Source/core/css/parser/SizesAttributeParser.cpp
+++ b/Source/core/css/parser/SizesAttributeParser.cpp
@@ -73,7 +73,7 @@ static void reverseSkipUntilComponentStart(MediaQueryTokenIterator& token, Media
bool SizesAttributeParser::mediaConditionMatches(PassRefPtrWillBeRawPtr<MediaQuerySet> mediaCondition)
{
- // FIXME: How do I handle non-screen media types here?
+ // A Media Condition cannot have a media type other then screen.
ojan 2014/05/16 18:21:56 Can you make this an ASSERT instead of a comment?
cbiesinger 2014/05/16 18:25:44 The comment is just explaining why the next line a
MediaQueryEvaluator mediaQueryEvaluator(MediaTypeNames::screen, *m_mediaValues);
return mediaQueryEvaluator.eval(mediaCondition.get());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698