Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Issue 2842623002: Remove whitelist from generate_perf_data (Closed)

Created:
3 years, 8 months ago by martiniss
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, ashleymarie1
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove whitelist from generate_perf_data Looks like this was added pre-swarming. It's unused, and undocumented, so just remove it. Review-Url: https://codereview.chromium.org/2842623002 Cr-Commit-Position: refs/heads/master@{#466840} Committed: https://chromium.googlesource.com/chromium/src/+/425afe03ad0dca72dce8d1334298bce08e3f353e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -30 lines) Patch
M tools/perf/core/perf_data_generator.py View 10 chunks +11 lines, -29 lines 0 comments Download
M tools/perf/core/perf_data_generator_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
martiniss
PTAL
3 years, 8 months ago (2017-04-24 23:00:09 UTC) #2
nednguyen
Negative CLs are the best CL! lgtm
3 years, 8 months ago (2017-04-24 23:18:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842623002/1
3 years, 8 months ago (2017-04-24 23:19:17 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 00:38:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/425afe03ad0dca72dce8d1334298...

Powered by Google App Engine
This is Rietveld 408576698