Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2842573004:
Adding and if-heavy aware integration test (Closed)
DescriptionAdding and if-heavy aware integration test
This CL adds a test to verify if-heavy is added on fast networks, but a
LoFi response is not received. It also adds a test to verify that slow2G
users will receieve a LoFi image for those requests.
BUG=708276
Review-Url: https://codereview.chromium.org/2842573004
Cr-Commit-Position: refs/heads/master@{#467748}
Committed: https://chromium.googlesource.com/chromium/src/+/bc74b94b7926f0322892fb5dd05d6c86194b13b9
Patch Set 1 #Patch Set 2 : python explicit line continuation #Patch Set 3 : fixed comment wording #
Total comments: 4
Patch Set 4 : robertogden comments #
Total comments: 4
Patch Set 5 : bengr nits #Messages
Total messages: 28 (19 generated)
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ryansturm@chromium.org changed reviewers: + bengr@chromium.org, robertogden@chromium.org
ryansturm@chromium.org changed reviewers: + bengr@chromium.org, robertogden@chromium.org
robertogden, bengr: PTAL, thanks
robertogden, bengr: PTAL, thanks
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2842573004/diff/40001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/lofi.py (right): https://codereview.chromium.org/2842573004/diff/40001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/lofi.py:102: # Verify that Lo-Fi responses were seen. s/were/were not/ https://codereview.chromium.org/2842573004/diff/40001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/lofi.py:103: self.assertNotEqual(0, non_lofi_responses) Wouldn't checking there were no lofi responses make more sense than checking there were non-lofi responses?
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2842573004/diff/40001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/lofi.py (right): https://codereview.chromium.org/2842573004/diff/40001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/lofi.py:102: # Verify that Lo-Fi responses were seen. On 2017/04/25 19:22:40, Robert Ogden wrote: > s/were/were not/ Done. https://codereview.chromium.org/2842573004/diff/40001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/lofi.py:103: self.assertNotEqual(0, non_lofi_responses) On 2017/04/25 19:22:39, Robert Ogden wrote: > Wouldn't checking there were no lofi responses make more sense than checking > there were non-lofi responses? self.checkLoFiResponse(response, False) checks that.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
LGTM. Please fix the CL description and the nits. https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/common.py (right): https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/common.py:589: then the request headers do too. If the CPAT header contains if-heavy, the Note somewhere that 'if-heavy' is being deprecated. https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/lofi.py (right): https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/lofi.py:44: # Disable server experiments such as tamper detection. nit: remove "such as tamper detection"
Description was changed from ========== Adding and if-heavy aware integration test This CL adds a test t overify if-heavy is added on fast networks, but a LoFi response is not received. It also adds a test to verify that slow2G users will receieve a LoFi image for those requests. BUG=708276 ========== to ========== Adding and if-heavy aware integration test This CL adds a test to verify if-heavy is added on fast networks, but a LoFi response is not received. It also adds a test to verify that slow2G users will receieve a LoFi image for those requests. BUG=708276 ==========
https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/common.py (right): https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/common.py:589: then the request headers do too. If the CPAT header contains if-heavy, the On 2017/04/27 18:45:49, bengr wrote: > Note somewhere that 'if-heavy' is being deprecated. Done. https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/lofi.py (right): https://codereview.chromium.org/2842573004/diff/60001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/lofi.py:44: # Disable server experiments such as tamper detection. On 2017/04/27 18:45:49, bengr wrote: > nit: remove "such as tamper detection" Done.
The CQ bit was checked by ryansturm@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertogden@chromium.org, bengr@chromium.org Link to the patchset: https://codereview.chromium.org/2842573004/#ps80001 (title: "bengr nits")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493319036378080,
"parent_rev": "f72420b280a531f5db4d636b8f1ad57cf20c9895", "commit_rev":
"bc74b94b7926f0322892fb5dd05d6c86194b13b9"}
Message was sent while issue was closed.
Description was changed from ========== Adding and if-heavy aware integration test This CL adds a test to verify if-heavy is added on fast networks, but a LoFi response is not received. It also adds a test to verify that slow2G users will receieve a LoFi image for those requests. BUG=708276 ========== to ========== Adding and if-heavy aware integration test This CL adds a test to verify if-heavy is added on fast networks, but a LoFi response is not received. It also adds a test to verify that slow2G users will receieve a LoFi image for those requests. BUG=708276 Review-Url: https://codereview.chromium.org/2842573004 Cr-Commit-Position: refs/heads/master@{#467748} Committed: https://chromium.googlesource.com/chromium/src/+/bc74b94b7926f0322892fb5dd05d... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/bc74b94b7926f0322892fb5dd05d... |
