Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2842573003: Convert mediastreamaudiosource to new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert mediastreamaudiosource to new Audit Manually convert to use new Audit. BUG=704967 TEST=constructor/mediastreamaudiosource.html Review-Url: https://codereview.chromium.org/2842573003 Cr-Commit-Position: refs/heads/master@{#468134} Committed: https://chromium.googlesource.com/chromium/src/+/17c53cea08706b1c1a280aac583d8fbef66d18d4

Patch Set 1 #

Patch Set 2 : Remove incorrect test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -42 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html View 1 1 chunk +24 lines, -42 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-26 14:59:29 UTC) #2
hongchan
lgtm
3 years, 7 months ago (2017-04-28 18:31:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842573003/20001
3 years, 7 months ago (2017-04-28 20:01:57 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 21:33:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17c53cea08706b1c1a280aac583d...

Powered by Google App Engine
This is Rietveld 408576698