Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2842553005: Fix test TabScrubberTest.FullScreenBrowser (Closed)

Created:
3 years, 8 months ago by weidongg
Modified:
3 years, 8 months ago
Reviewers:
afakhry, James Cook
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix test TabScrubberTest.FullScreenBrowser The test times out due to the interference of mouse. When a mouse hovers above the tab strip, the immersive mode reveal never ends. Solution is to initialize the mouse position to make it away from the tabstrip. BUG=708612 TEST=interactive_ui_tests --gtest_filter=TabScrubberTest.FullScreenBrowser Review-Url: https://codereview.chromium.org/2842553005 Cr-Commit-Position: refs/heads/master@{#467206} Committed: https://chromium.googlesource.com/chromium/src/+/c1f175f856da8298510aa3085b194342c00dfc7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
weidongg
3 years, 8 months ago (2017-04-26 00:07:17 UTC) #2
James Cook
LGTM
3 years, 8 months ago (2017-04-26 01:09:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842553005/1
3 years, 8 months ago (2017-04-26 02:19:37 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 02:25:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1f175f856da8298510aa3085b19...

Powered by Google App Engine
This is Rietveld 408576698