Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2842543002: MD Settings: indent "OK Google" row in "Search engine" section (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: indent "OK Google" row in "Search engine" section R=stevenjb@chromium.org BUG=714103 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2842543002 Cr-Commit-Position: refs/heads/master@{#466869} Committed: https://chromium.googlesource.com/chromium/src/+/8ee9a70477b5f291ddfeae7f6b57716cf814075b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/search_page/search_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Dan Beam
3 years, 8 months ago (2017-04-24 19:29:05 UTC) #2
stevenjb
lgtm
3 years, 8 months ago (2017-04-24 20:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842543002/1
3 years, 8 months ago (2017-04-25 00:35:51 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 02:01:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ee9a70477b5f291ddfeae7f6b57...

Powered by Google App Engine
This is Rietveld 408576698