Move FreeType bundling on mac OS from PDFium up to Chrome

Move FreeType bundling on mac OS from PDFium up to Chrome

Preparation for using FreeType on older mac OS versions for supporting
OpenType variable fonts.

Introduce a MAC_RESTRICT_VISIBILITY define in the FreeType build in
order not to expose FreeType symbols on the main executable on Mac,
since there is a symbol visibility check build-step which breaks if it
finds FreeType symbols there.

BUG=714553
Review-Url: https://codereview.chromium.org/2842513004
Cr-Commit-Position: refs/heads/master@{#467593}
Committed: https://chromium.googlesource.com/chromium/src/+/e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5

[drott, 2017-04-25 02:01:16]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 02:02:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 02:20:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 02:20:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[drott, 2017-04-26 02:26:42]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 02:27:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 02:47:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2017-04-26 06:57:20]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 06:57:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 08:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 08:06:13]

Dry run: This issue passed the CQ dry run.

[drott, 2017-04-26 08:42:10]

drott@chromium.org changed reviewers:
+ bungeman@chromium.org, kjellander@chromium.org, machenbach@chromium.org,
thestig@chromium.org

[drott, 2017-04-26 08:43:20]

machenbach@, kjellander@: Please review build_overrides/*

thestig@, PTAL, does this look okay to you? I plan to use FreeType on older mac
OS in Blink for Variations in a next step.

[drott, 2017-04-26 08:45:14]

Description was changed from

==========
Move FreeType bundling on mac OS from PDFium up to Chrome

Preparation for using FreeType on older mac OS versions for supporting
OpenType variable fonts.

BUG=714553
==========

to

==========
Move FreeType bundling on mac OS from PDFium up to Chrome

Preparation for using FreeType on older mac OS versions for supporting
OpenType variable fonts.

Introduce a MAC_RESTRICT_VISIBILITY define in the FreeType build in
order not to expose FreeType symbols on the main executable on Mac,
since there is a symbol visibility check build-step which breaks if it
finds FreeType symbols there.

BUG=714553
==========

[kjellander_chromium, 2017-04-26 08:54:07]

build_overrides: lgtm

[bungeman-chromium, 2017-04-26 14:22:19]

Aside from the DEPS duplication, lgtm.

https://codereview.chromium.org/2842513004/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/2842513004/diff/40001/DEPS#newcode396
DEPS:396: 'src/third_party/freetype/src':
Looks like we're already doing this in this 'mac' entry? Also, now that we're
DEPSing this on 'mac', 'win', 'unix', and 'android' is there a good reason not
to always DEPS it in? It appears we have this entry copy pasted into every
deps_os entry at the moment.

[Dirk Pranke, 2017-04-26 19:20:49]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-04-26 19:20:50]

https://codereview.chromium.org/2842513004/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/2842513004/diff/40001/DEPS#newcode396
DEPS:396: 'src/third_party/freetype/src':
On 2017/04/26 14:22:19, bungeman-chromium wrote:
> Looks like we're already doing this in this 'mac' entry? Also, now that we're
> DEPSing this on 'mac', 'win', 'unix', and 'android' is there a good reason not
> to always DEPS it in? It appears we have this entry copy pasted into every
> deps_os entry at the moment.

+1 :)

[drott, 2017-04-27 02:30:34]

The CQ bit was checked by drott@chromium.org

[drott, 2017-04-27 02:30:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org, bungeman@chromium.org
Link to the patchset: https://codereview.chromium.org/2842513004/#ps60001
(title: "Freetype as a general dependency in DEPS")

[commit-bot: I haz the power, 2017-04-27 02:31:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-04-27 03:33:57]

On 2017/04/26 08:43:20, drott wrote:
> thestig@, PTAL, does this look okay to you? I plan to use FreeType on older
mac
> OS in Blink for Variations in a next step.

PDFium usage is fine with me.

[commit-bot: I haz the power, 2017-04-27 05:10:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 05:10:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2017-04-27 05:10:59]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-04-27 05:11:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 05:44:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493269859246610,
"parent_rev": "67b9f6e761fba98d3a3e80edec863d2b97ff79a5", "commit_rev":
"e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5"}

[commit-bot: I haz the power, 2017-04-27 05:44:35]

Description was changed from

==========
Move FreeType bundling on mac OS from PDFium up to Chrome

Preparation for using FreeType on older mac OS versions for supporting
OpenType variable fonts.

Introduce a MAC_RESTRICT_VISIBILITY define in the FreeType build in
order not to expose FreeType symbols on the main executable on Mac,
since there is a symbol visibility check build-step which breaks if it
finds FreeType symbols there.

BUG=714553
==========

to

==========
Move FreeType bundling on mac OS from PDFium up to Chrome

Preparation for using FreeType on older mac OS versions for supporting
OpenType variable fonts.

Introduce a MAC_RESTRICT_VISIBILITY define in the FreeType build in
order not to expose FreeType symbols on the main executable on Mac,
since there is a symbol visibility check build-step which breaks if it
finds FreeType symbols there.

BUG=714553

Review-Url: https://codereview.chromium.org/2842513004
Cr-Commit-Position: refs/heads/master@{#467593}
Committed:
https://chromium.googlesource.com/chromium/src/+/e30ecdc92de704ab362ed77b2c0c...
==========

[commit-bot: I haz the power, 2017-04-27 05:44:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e30ecdc92de704ab362ed77b2c0c...