Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2842513002: Update nacl SDK code to match recent changes to lastchange.py (Closed)

Created:
3 years, 8 months ago by Sam Clegg
Modified:
3 years, 8 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update nacl SDK code to match recent changes to lastchange.py The API in laschange.py recently changed with https://codereview.chromium.org/2826263003. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk BUG=629626 Review-Url: https://codereview.chromium.org/2842513002 Cr-Commit-Position: refs/heads/master@{#466764} Committed: https://chromium.googlesource.com/chromium/src/+/060db36535689ed73b7c453726a07b4185074938

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M native_client_sdk/src/build_tools/build_version.py View 1 5 chunks +9 lines, -10 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/build_version_test.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Sam Clegg
3 years, 8 months ago (2017-04-24 20:20:31 UTC) #5
binji
lgtm
3 years, 8 months ago (2017-04-24 20:54:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842513002/20001
3 years, 8 months ago (2017-04-24 20:58:25 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 21:10:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/060db36535689ed73b7c453726a0...

Powered by Google App Engine
This is Rietveld 408576698