Add OnceCallback support to PostTaskAndReplyWithResult

Add OnceCallback support to PostTaskAndReplyWithResult

This CL adds OnceCallback support to PostTaskAndReplyWithResult impls in
task_runner_util.h and browser_thread.h, which are left overs of the
OnceCallback support of PostTask family.

In addition, this CL removes the function pointer usage of PTARWR in
//components/drive, so that we can define an overload of PTARWR for
legacy base::Callback.

BUG=714018
Review-Url: https://codereview.chromium.org/2842493004
Cr-Commit-Position: refs/heads/master@{#468680}
Committed: https://chromium.googlesource.com/chromium/src/+/d5346b598e8bb9c72acd8a81e51a593e99f23829

[tzik, 2017-04-25 07:15:20]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[tzik, 2017-04-25 07:27:57]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 07:28:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 07:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 07:45:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-04-25 08:34:26]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 08:34:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 08:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 08:52:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-04-28 11:53:15]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 11:53:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-28 11:57:58]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 11:58:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-28 12:04:22]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 12:04:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 13:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 13:28:51]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-05-01 04:11:35]

Description was changed from

==========
Add OnceCallback support to PostTaskAndReplyWithResult

BUG=
==========

to

==========
Add OnceCallback support to PostTaskAndReplyWithResult

This CL adds OnceCallback support to PostTaskAndReplyWithResult impls in
task_runner_util.h and browser_thread.h, which are left overs of the
OnceCallback support of PostTask family.

In addition, this CL removes the function pointer usage of PTARWR in
//components/drive, so that we can define an overload of PTARWR for
legacy base::Callback.
==========

[tzik, 2017-05-01 04:11:35]

tzik@chromium.org changed reviewers:
+ gab@chromium.org, kinaba@chromium.org

[tzik, 2017-05-01 04:12:45]

Description was changed from

==========
Add OnceCallback support to PostTaskAndReplyWithResult

This CL adds OnceCallback support to PostTaskAndReplyWithResult impls in
task_runner_util.h and browser_thread.h, which are left overs of the
OnceCallback support of PostTask family.

In addition, this CL removes the function pointer usage of PTARWR in
//components/drive, so that we can define an overload of PTARWR for
legacy base::Callback.
==========

to

==========
Add OnceCallback support to PostTaskAndReplyWithResult

This CL adds OnceCallback support to PostTaskAndReplyWithResult impls in
task_runner_util.h and browser_thread.h, which are left overs of the
OnceCallback support of PostTask family.

In addition, this CL removes the function pointer usage of PTARWR in
//components/drive, so that we can define an overload of PTARWR for
legacy base::Callback.

BUG=714018
==========

[tzik, 2017-05-01 04:12:45]

tzik@chromium.org changed reviewers:
+ kinuko@chromium.org

[tzik, 2017-05-01 04:13:15]

PTAL to:
kinaba: //components/drive
gab: //base
kinuko: //content

[kinaba, 2017-05-01 04:28:45]

components/drive lgtm

[kinuko, 2017-05-01 04:48:47]

lgtm

https://codereview.chromium.org/2842493004/diff/100001/content/public/browser...
File content/public/browser/browser_thread.h (right):

https://codereview.chromium.org/2842493004/diff/100001/content/public/browser...
content/public/browser/browser_thread.h:157: // TODO(tzik): Update all callers
of the Callback version to use OnceCallback.
nit: link to the issue?

[tzik, 2017-05-01 05:06:55]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 05:07:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-01 05:13:01]

https://codereview.chromium.org/2842493004/diff/100001/content/public/browser...
File content/public/browser/browser_thread.h (right):

https://codereview.chromium.org/2842493004/diff/100001/content/public/browser...
content/public/browser/browser_thread.h:157: // TODO(tzik): Update all callers
of the Callback version to use OnceCallback.
On 2017/05/01 04:48:47, kinuko wrote:
> nit: link to the issue?

Done.

[commit-bot: I haz the power, 2017-05-01 06:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 06:21:23]

Dry run: This issue passed the CQ dry run.

[gab, 2017-05-01 18:14:35]

base lgtm w/ comment

https://codereview.chromium.org/2842493004/diff/120001/base/task_runner_util.h
File base/task_runner_util.h (right):

https://codereview.chromium.org/2842493004/diff/120001/base/task_runner_util....
base/task_runner_util.h:51: // we can not use template deduction and object
conversion at once on the
s/can not/cannot/

https://codereview.chromium.org/2842493004/diff/120001/base/task_runner_util....
base/task_runner_util.h:63:
static_cast<OnceCallback<void(ReplyArgType)>>(std::move(reply)));
Use copy constructor directly instead of static_cast
(same as
https://codereview.chromium.org/2637843002/diff/460001/base/task_scheduler/po...)

[tzik, 2017-05-02 15:28:12]

https://codereview.chromium.org/2842493004/diff/120001/base/task_runner_util.h
File base/task_runner_util.h (right):

https://codereview.chromium.org/2842493004/diff/120001/base/task_runner_util....
base/task_runner_util.h:51: // we can not use template deduction and object
conversion at once on the
On 2017/05/01 18:14:35, gab wrote:
> s/can not/cannot/

Done.

https://codereview.chromium.org/2842493004/diff/120001/base/task_runner_util....
base/task_runner_util.h:63:
static_cast<OnceCallback<void(ReplyArgType)>>(std::move(reply)));
On 2017/05/01 18:14:35, gab wrote:
> Use copy constructor directly instead of static_cast
> (same as
>
https://codereview.chromium.org/2637843002/diff/460001/base/task_scheduler/po...)

Ah, I forgot it. Done.

[tzik, 2017-05-02 15:28:25]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-05-02 15:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
kinaba@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2842493004/#ps160001
(title: "s/can not/cannot/")

[commit-bot: I haz the power, 2017-05-02 15:29:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 16:48:22]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493738905858020,
"parent_rev": "89a19c7dd35d9d855fc11b75a154ebbe2ae68c2b", "commit_rev":
"d5346b598e8bb9c72acd8a81e51a593e99f23829"}

[commit-bot: I haz the power, 2017-05-02 16:48:37]

Description was changed from

==========
Add OnceCallback support to PostTaskAndReplyWithResult

This CL adds OnceCallback support to PostTaskAndReplyWithResult impls in
task_runner_util.h and browser_thread.h, which are left overs of the
OnceCallback support of PostTask family.

In addition, this CL removes the function pointer usage of PTARWR in
//components/drive, so that we can define an overload of PTARWR for
legacy base::Callback.

BUG=714018
==========

to

==========
Add OnceCallback support to PostTaskAndReplyWithResult

This CL adds OnceCallback support to PostTaskAndReplyWithResult impls in
task_runner_util.h and browser_thread.h, which are left overs of the
OnceCallback support of PostTask family.

In addition, this CL removes the function pointer usage of PTARWR in
//components/drive, so that we can define an overload of PTARWR for
legacy base::Callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2842493004
Cr-Commit-Position: refs/heads/master@{#468680}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5346b598e8bb9c72acd8a81e51a...
==========

[commit-bot: I haz the power, 2017-05-02 16:48:38]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/d5346b598e8bb9c72acd8a81e51a...