Fix use-after-move in media/webrtc permission prompting code

Fix use-after-move in media/webrtc permission prompting code

Accessing a unique_ptr in the same call expression that moves it is
generally not safe, since different compilers evaluate have different
orders of evaluation.

BUG=714609
TBR=raymes@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2842493003
Cr-Commit-Position: refs/heads/master@{#466830}
Committed: https://chromium.googlesource.com/chromium/src/+/27ae42407b0effd81dd43d7542305f5cc1aa1d58

[Reid Kleckner, 2017-04-24 23:18:11]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:18:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 23:59:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493075891346440, "parent_rev":
"d68163e0c6061c0bd6ab8bade6d6fd9ea81a3c02", "commit_rev":
"27ae42407b0effd81dd43d7542305f5cc1aa1d58"}

[commit-bot: I haz the power, 2017-04-24 23:59:51]

Description was changed from

==========
Fix use-after-move in media/webrtc permission prompting code

Accessing a unique_ptr in the same call expression that moves it is
generally not safe, since different compilers evaluate have different
orders of evaluation.

BUG=714609
TBR=raymes@chromium.org,thakis@chromium.org
==========

to

==========
Fix use-after-move in media/webrtc permission prompting code

Accessing a unique_ptr in the same call expression that moves it is
generally not safe, since different compilers evaluate have different
orders of evaluation.

BUG=714609
TBR=raymes@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2842493003
Cr-Commit-Position: refs/heads/master@{#466830}
Committed:
https://chromium.googlesource.com/chromium/src/+/27ae42407b0effd81dd43d754230...
==========

[commit-bot: I haz the power, 2017-04-24 23:59:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27ae42407b0effd81dd43d754230...

[Nico, 2017-04-25 00:15:47]

lgtm

https://bugs.chromium.org/p/chromium/issues/detail?id=409318#c16 strikes again
– but I guess the base::Passed(&foo) idiom means the llvm-side implementation of
this warning wouldn't fire in all cases :-/

[raymes, 2017-04-25 22:07:31]

Thanks for the fix!