Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2842443002: Create NavigationContext right after the navigation was started. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create NavigationContext right after the navigation was started. This CL (7 of 7) is a part of large refactoring to create NavigationContext when navigation was started, not when it is finished. This refactoring will allow to pass the same instance of NavigationContext to DidStartNavigation and DidFinishNavigation (crbug.com/713836). Also this will allow to associate NavigationItem with NavigationContext object to commit non-latest navigation (crbug.com/712269). This CL changes the time of NavigationContext creation. Subsequent CLs will fix: - crbug.com/713836 by passing NavigationContext to OnProvisionalNavigationStarted - crbug.com/712269 by looking up for pending NavigationContext and extracting NavigationItem from it BUG=713836, 712269 Review-Url: https://codereview.chromium.org/2842443002 Cr-Commit-Position: refs/heads/master@{#470687} Committed: https://chromium.googlesource.com/chromium/src/+/756b09442132dec9b01cbeda19d0a8d69e8dd551

Patch Set 1 #

Patch Set 2 : Updated comments #

Patch Set 3 : Reverted extra changes #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Patch Set 6 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -38 lines) Patch
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 3 4 5 21 chunks +81 lines, -32 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-24 14:04:36 UTC) #2
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-04 19:07:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842443002/80001
3 years, 7 months ago (2017-05-10 15:13:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/211687)
3 years, 7 months ago (2017-05-10 15:47:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842443002/100001
3 years, 7 months ago (2017-05-10 20:14:29 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:29:00 UTC) #19
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/756b09442132dec9b01cbeda19d0...

Powered by Google App Engine
This is Rietveld 408576698