Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2842393003: wpt-import: Work on third_party/WebKit/LayoutTests instead of third_party/WebKit. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

wpt-import: Work on third_party/WebKit/LayoutTests instead of third_party/WebKit. To reduce path_from_webkit_base() usage. - Remove rmtree() Only one callsite, and it called this function with an absolute path. - Remove relative path resolution in remove() There are two callsites, and only one of them passed relative paths. This CL should have no functional changes. BUG=710535 Review-Url: https://codereview.chromium.org/2842393003 Cr-Commit-Position: refs/heads/master@{#467828} Committed: https://chromium.googlesource.com/chromium/src/+/5c989879d70ea7b5c484175ad70315e32f505b44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 6 chunks +8 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
jeffcarp@, would you review this please?
3 years, 8 months ago (2017-04-27 08:35:43 UTC) #7
jeffcarp
lgtm
3 years, 7 months ago (2017-04-27 21:32:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842393003/1
3 years, 7 months ago (2017-04-28 01:43:22 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 02:00:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c989879d70ea7b5c484175ad703...

Powered by Google App Engine
This is Rietveld 408576698