Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2842373005: [ic] Handle JSArray::length in CodeStubAssembler::CallGetterIfAccessor. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Handle JSArray::length in CodeStubAssembler::CallGetterIfAccessor. When accessing JSArray::length property from GenericPropertyLoad (i.e. via a megamorphic KEYED_LOAD_IC), we'd always go to the runtime at this point, because the CallGetterIfAccessor method didn't support AccessorInfos at all. Now there's initial support for JSArray::length, which reduces the number of %KeyedGetProperty calls we see in the Speedometer/EmberJS test by 5000. Also-By: ishell@chromium.org BUG=v8:5269 TBR=ishell@chromium.org Review-Url: https://codereview.chromium.org/2842373005 Cr-Commit-Position: refs/heads/master@{#44957} Committed: https://chromium.googlesource.com/v8/v8/+/0be5596cdb2becaf746a2de3564cac9547be4874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M src/code-stub-assembler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 3 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Benedikt Meurer
3 years, 7 months ago (2017-04-28 03:51:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842373005/1
3 years, 7 months ago (2017-04-28 03:52:13 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 04:20:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0be5596cdb2becaf746a2de3564cac9547b...

Powered by Google App Engine
This is Rietveld 408576698