Getting answer server URL from the variations server.

Getting answer server URL from the variations server.

Passing via command line is still supported, and has priority over the variations server parameter.

Bug=712331
Review-Url: https://codereview.chromium.org/2842363002
Cr-Commit-Position: refs/heads/master@{#467536}
Committed: https://chromium.googlesource.com/chromium/src/+/82836763ab1e42bff177e272ef88656aa6dbaf9b

[vadimt, 2017-04-26 23:06:53]

vadimt@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2017-04-26 23:18:00]

lgtm

https://codereview.chromium.org/2842363002/diff/1/ui/app_list/app_list_switch...
File ui/app_list/app_list_switches.cc (right):

https://codereview.chromium.org/2842363002/diff/1/ui/app_list/app_list_switch...
ui/app_list/app_list_switches.cc:85: std::string variations_url =
base::GetFieldTrialParamValue(
nit: get rid of |variations_url| and inline GetFieldTrialParamValue. So that we
only call it when there is no command line switch.

https://codereview.chromium.org/2842363002/diff/1/ui/app_list/app_list_switch...
ui/app_list/app_list_switches.cc:87: std::string url =
nit: const

[vadimt, 2017-04-26 23:29:42]

Still LGTM?

https://codereview.chromium.org/2842363002/diff/1/ui/app_list/app_list_switch...
File ui/app_list/app_list_switches.cc (right):

https://codereview.chromium.org/2842363002/diff/1/ui/app_list/app_list_switch...
ui/app_list/app_list_switches.cc:85: std::string variations_url =
base::GetFieldTrialParamValue(
See the links I'll send. Quote:

  // Note: It's important to query the field trial state first, to ensure that
  // UMA reports the correct group.

https://codereview.chromium.org/2842363002/diff/1/ui/app_list/app_list_switch...
ui/app_list/app_list_switches.cc:87: std::string url =
Done.
I like consts, but I'm not using them in Chrome since this doesn't seem to be a
common practice. I don't want my style to deviate from the average.

[vadimt, 2017-04-26 23:36:47]

The CQ bit was checked by vadimt@chromium.org

[vadimt, 2017-04-26 23:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2842363002/#ps20001
(title: "Reviewer's comments")

[commit-bot: I haz the power, 2017-04-26 23:37:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:59:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493249807823710,
"parent_rev": "30474f06441fe7325ce99815f6337e2f9d425b7e", "commit_rev":
"82836763ab1e42bff177e272ef88656aa6dbaf9b"}

[commit-bot: I haz the power, 2017-04-27 01:00:39]

Description was changed from

==========
Getting answer server URL from the variations server.

Passing via command line is still supported, and has priority over the
variations server parameter.

Bug=712331
==========

to

==========
Getting answer server URL from the variations server.

Passing via command line is still supported, and has priority over the
variations server parameter.

Bug=712331

Review-Url: https://codereview.chromium.org/2842363002
Cr-Commit-Position: refs/heads/master@{#467536}
Committed:
https://chromium.googlesource.com/chromium/src/+/82836763ab1e42bff177e272ef88...
==========

[commit-bot: I haz the power, 2017-04-27 01:00:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/82836763ab1e42bff177e272ef88...