Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2842323002: Treat zero-width collapsed borders as invisible (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat zero-width collapsed borders as invisible We have fast-path for invisible collapsed borders. Treating zero- width as invisible can improve performance in the case. Also move core/style/CollapsedBorderValue.h to core/layout because the structure is not used by any style code. This CL will reduce frame time of PerformanceTests/Mutation/background-change-with-zero-width-collapsed-borders.html (in https://codereview.chromium.org/2842313002/) by about 50%. Review-Url: https://codereview.chromium.org/2842323002 Cr-Commit-Position: refs/heads/master@{#467741} Committed: https://chromium.googlesource.com/chromium/src/+/4a9e4e47495a1c039b1948309bb45bdb8a88f6b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -112 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/CollapsedBorderValue.h View 3 chunks +15 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/style/CollapsedBorderValue.h View 1 chunk +0 lines, -93 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Xianzhu
3 years, 8 months ago (2017-04-26 22:02:16 UTC) #4
pdr.
You had me at -50% LGTM
3 years, 8 months ago (2017-04-26 22:19:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842323002/1
3 years, 7 months ago (2017-04-27 15:41:10 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:08:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a9e4e47495a1c039b1948309bb4...

Powered by Google App Engine
This is Rietveld 408576698