Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Issue 2842303003: [heap] Remove max executable size configuration. (Closed)

Created:
3 years, 7 months ago by Hannes Payer (out of office)
Modified:
3 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove max executable size configuration. BUG=chromium:716032 Review-Url: https://codereview.chromium.org/2842303003 Cr-Commit-Position: refs/heads/master@{#44975} Committed: https://chromium.googlesource.com/v8/v8/+/1e50277b9fa61a162874e33027083a20f348c555

Patch Set 1 #

Patch Set 2 : init #

Patch Set 3 : limit buffer on platforms #

Patch Set 4 : format #

Patch Set 5 : platform support #

Patch Set 6 : platform support #

Total comments: 2

Patch Set 7 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -73 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 2 3 4 5 1 chunk +8 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 2 3 4 5 1 chunk +8 lines, -1 line 0 comments Download
M src/assembler.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 2 3 4 1 chunk +1 line, -4 lines 0 comments Download
M src/heap/heap.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/heap/heap.cc View 7 chunks +3 lines, -21 lines 0 comments Download
M src/heap/spaces.h View 3 chunks +1 line, -11 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +1 line, -13 lines 0 comments Download
M src/mips/assembler-mips.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 2 3 4 5 1 chunk +9 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 2 3 4 5 1 chunk +9 lines, -2 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M src/s390/assembler-s390.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M test/cctest/heap/test-spaces.cc View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 28 (23 generated)
Hannes Payer (out of office)
3 years, 7 months ago (2017-04-28 10:12:37 UTC) #20
ulan
lgtm! https://codereview.chromium.org/2842303003/diff/100001/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): https://codereview.chromium.org/2842303003/diff/100001/src/arm/assembler-arm.h#newcode1727 src/arm/assembler-arm.h:1727: static const int kMaximalBufferSize = 512*MB; Nit: space ...
3 years, 7 months ago (2017-04-28 10:52:22 UTC) #21
Hannes Payer (out of office)
https://codereview.chromium.org/2842303003/diff/100001/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): https://codereview.chromium.org/2842303003/diff/100001/src/arm/assembler-arm.h#newcode1727 src/arm/assembler-arm.h:1727: static const int kMaximalBufferSize = 512*MB; On 2017/04/28 10:52:22, ...
3 years, 7 months ago (2017-04-28 11:08:58 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842303003/120001
3 years, 7 months ago (2017-04-28 11:08:59 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 11:41:12 UTC) #28
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/1e50277b9fa61a162874e33027083a20f34...

Powered by Google App Engine
This is Rietveld 408576698