Adding macOS notes on the rich notification article

Adding macOS notes on the rich notification article

BUG=715691
Review-Url: https://codereview.chromium.org/2842293002
Cr-Commit-Position: refs/heads/master@{#467690}
Committed: https://chromium.googlesource.com/chromium/src/+/dccdf8bfe040e02eb4944fb1a2767ace9a32ce45

[mattgaunt, 2017-04-26 20:54:11]

Description was changed from

==========
Adding macOS notes on the rich notification article

BUG=
==========

to

==========
Adding macOS notes on the rich notification article

BUG=
==========

[mattgaunt, 2017-04-26 20:54:11]

mattgaunt@google.com changed reviewers:
+ mkearney@google.com

[Peter Beverloo, 2017-04-26 21:01:09]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-04-26 21:01:10]

lgtm % nits

https://codereview.chromium.org/2842293002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/templates/articles/richNotifications.html
(right):

https://codereview.chromium.org/2842293002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/richNotifications.html:4:
<strong>Platform Difference:</strong> In Chrome version 59 the appearance of
Why not use "Platform difference"? I think we only capitalise titles like this?

https://codereview.chromium.org/2842293002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/richNotifications.html:189:
displayed to users in Chrome version 59+ on macOS.
You call this "macOS", I call this "Mac OS X". We should converge. Do you have a
preference?

[mkearney1, 2017-04-26 23:29:36]

mkearney@chromium.org changed reviewers:
+ mkearney@chromium.org

[mkearney1, 2017-04-26 23:29:37]

Just some small nits but otherwise... lgtm

https://codereview.chromium.org/2842293002/diff/20001/chrome/common/extension...
File chrome/common/extensions/docs/templates/articles/richNotifications.html
(right):

https://codereview.chromium.org/2842293002/diff/20001/chrome/common/extension...
chrome/common/extensions/docs/templates/articles/richNotifications.html:5:
notifications will be different for Mac OS X users. Instead of Chrome's own
Small nit: missing comma. In Chrome version 59,

https://codereview.chromium.org/2842293002/diff/20001/chrome/common/extension...
chrome/common/extensions/docs/templates/articles/richNotifications.html:7: <a
href="https://developers.google.com/web/updates/2017/04/native-mac-os-notifications">Learn
more in this article</a>.
Another small nit-- active rather than passive voice:

In Chrome version 59, notifications appear differently for Mac OS X users.
Instead of Chrome's own notifications, users see Mac OS X notifications.

https://codereview.chromium.org/2842293002/diff/20001/chrome/common/extension...
chrome/common/extensions/docs/templates/articles/richNotifications.html:83: </p>
Small nit-- a bit more active:

The priority does not affect the order of notifications in Chrome version 59+ on
Mac OS X.

https://codereview.chromium.org/2842293002/diff/20001/chrome/common/extension...
chrome/common/extensions/docs/templates/articles/richNotifications.html:191: 
Small nit, more active... "Only the first list item is..."

https://codereview.chromium.org/2842293002/diff/20001/chrome/common/extension...
chrome/common/extensions/docs/templates/articles/richNotifications.html:216: 
Small nit (typo and more active): 

In Chrome version 59+ on Mac OS X, the progress bar displays as a percentage
value in the title of the notification instead of displaying a progress bar.

[mattgaunt, 2017-04-27 15:17:35]

Description was changed from

==========
Adding macOS notes on the rich notification article

BUG=
==========

to

==========
Adding macOS notes on the rich notification article

BUG=715691
==========

[mattgaunt, 2017-04-27 15:32:43]

The CQ bit was checked by mattgaunt@google.com

[mattgaunt, 2017-04-27 15:32:44]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
mkearney@chromium.org
Link to the patchset: https://codereview.chromium.org/2842293002/#ps40001
(title: "Fixing Meggins Comments")

[commit-bot: I haz the power, 2017-04-27 15:33:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 15:44:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493307163630160,
"parent_rev": "499dce94255c5175beeb668c2bdd7a9fc8a6576b", "commit_rev":
"dccdf8bfe040e02eb4944fb1a2767ace9a32ce45"}

[commit-bot: I haz the power, 2017-04-27 15:44:57]

Description was changed from

==========
Adding macOS notes on the rich notification article

BUG=715691
==========

to

==========
Adding macOS notes on the rich notification article

BUG=715691

Review-Url: https://codereview.chromium.org/2842293002
Cr-Commit-Position: refs/heads/master@{#467690}
Committed:
https://chromium.googlesource.com/chromium/src/+/dccdf8bfe040e02eb4944fb1a276...
==========

[commit-bot: I haz the power, 2017-04-27 15:45:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dccdf8bfe040e02eb4944fb1a276...