Switch SupportsUserData uses to use unique_ptr.

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
Review-Url: https://codereview.chromium.org/2842263003
Cr-Commit-Position: refs/heads/master@{#467613}
Committed: https://chromium.googlesource.com/chromium/src/+/0d99147557a46a8cd12bc827fb7a75e6bfa67097

[Avi (use Gerrit), 2017-04-27 03:33:57]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 03:34:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-04-27 04:03:31]

avi@chromium.org changed reviewers:
+ mattm@chromium.org

[mattm, 2017-04-27 04:58:11]

lgtm with nit

https://codereview.chromium.org/2842263003/diff/1/net/websockets/websocket_st...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/2842263003/diff/1/net/websockets/websocket_st...
net/websockets/websocket_stream.cc:96:
handshake_stream_create_helper_(create_helper.release()),
would be cleaner to use create_helper.get() here and std::move(create_helper)
below

[Avi (use Gerrit), 2017-04-27 05:05:44]

https://codereview.chromium.org/2842263003/diff/1/net/websockets/websocket_st...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/2842263003/diff/1/net/websockets/websocket_st...
net/websockets/websocket_stream.cc:96:
handshake_stream_create_helper_(create_helper.release()),
On 2017/04/27 04:58:11, mattm wrote:
> would be cleaner to use create_helper.get() here and std::move(create_helper)
> below

Why is handshake_stream_create_helper_ even a member?

[Avi (use Gerrit), 2017-04-27 05:05:56]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-04-27 05:05:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2842263003/#ps20001
(title: "clean")

[commit-bot: I haz the power, 2017-04-27 05:06:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-27 05:15:27]

https://codereview.chromium.org/2842263003/diff/1/net/websockets/websocket_st...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/2842263003/diff/1/net/websockets/websocket_st...
net/websockets/websocket_stream.cc:96:
handshake_stream_create_helper_(create_helper.release()),
On 2017/04/27 05:05:44, Avi (ping after 24h) wrote:
> On 2017/04/27 04:58:11, mattm wrote:
> > would be cleaner to use create_helper.get() here and
std::move(create_helper)
> > below
> 
> Why is handshake_stream_create_helper_ even a member?

Good point. (I'm not familiar with the history of this code.)

[commit-bot: I haz the power, 2017-04-27 07:04:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493269556924270,
"parent_rev": "c083e9097f40b9618834c7f845e46fa1dd5d7ee0", "commit_rev":
"0d99147557a46a8cd12bc827fb7a75e6bfa67097"}

[commit-bot: I haz the power, 2017-04-27 07:04:17]

Description was changed from

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
==========

to

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2842263003
Cr-Commit-Position: refs/heads/master@{#467613}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d99147557a46a8cd12bc827fb7a...
==========

[commit-bot: I haz the power, 2017-04-27 07:04:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d99147557a46a8cd12bc827fb7a...