Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 284223004: List cloud devices in chrome://devices page. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

List cloud devices in chrome://devices page. BUG=374349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271473

Patch Set 1 : Fri 05/16/2014 12:52:36.94 #

Total comments: 6

Patch Set 2 : Fri 05/16/2014 16:57:21.63 #

Patch Set 3 : Sat 05/17/2014 10:06:17.58 #

Patch Set 4 : Mon 05/19/2014 10:06:12.06 #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -195 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
A chrome/browser/local_discovery/cloud_device_list.h View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/cloud_device_list.cc View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/cloud_device_list_delegate.h View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/cloud_device_list_delegate.cc View 1 2 3 4 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/cloud_device_list_unittest.cc View 1 2 1 chunk +120 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/cloud_print_printer_list.h View 1 2 2 chunks +12 lines, -35 lines 0 comments Download
M chrome/browser/local_discovery/cloud_print_printer_list.cc View 1 2 6 chunks +13 lines, -31 lines 0 comments Download
M chrome/browser/local_discovery/cloud_print_printer_list_unittest.cc View 1 2 3 chunks +28 lines, -53 lines 0 comments Download
M chrome/browser/local_discovery/gcd_base_api_flow.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/gcd_base_api_flow.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 5 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 2 7 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 2 7 chunks +100 lines, -49 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Vitaly Buka (NO REVIEWS)
List cloud devices in chrome://devices page. BUG=374349
6 years, 7 months ago (2014-05-16 19:43:31 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-16 19:52:03 UTC) #2
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-16 19:52:13 UTC) #3
Noam Samuel
https://codereview.chromium.org/284223004/diff/50001/chrome/browser/local_discovery/cloud_device_list.cc File chrome/browser/local_discovery/cloud_device_list.cc (right): https://codereview.chromium.org/284223004/diff/50001/chrome/browser/local_discovery/cloud_device_list.cc#newcode85 chrome/browser/local_discovery/cloud_device_list.cc:85: !device_value->GetString("systemName", &details->display_name)) { Nit: Why are these two chained ...
6 years, 7 months ago (2014-05-16 21:13:26 UTC) #4
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/284223004/diff/50001/chrome/browser/local_discovery/cloud_device_list.cc File chrome/browser/local_discovery/cloud_device_list.cc (right): https://codereview.chromium.org/284223004/diff/50001/chrome/browser/local_discovery/cloud_device_list.cc#newcode85 chrome/browser/local_discovery/cloud_device_list.cc:85: !device_value->GetString("systemName", &details->display_name)) { On 2014/05/16 21:13:26, Noam Samuel wrote: ...
6 years, 7 months ago (2014-05-17 17:15:37 UTC) #5
Noam Samuel
lgtm
6 years, 7 months ago (2014-05-19 16:36:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/284223004/130001
6 years, 7 months ago (2014-05-19 16:37:00 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-19 17:07:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/284223004/140001
6 years, 7 months ago (2014-05-19 17:08:38 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-19 18:11:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/284223004/160001
6 years, 7 months ago (2014-05-19 18:12:40 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 20:48:05 UTC) #12
Message was sent while issue was closed. 
Change committed as 271473

Powered by Google App Engine
This is Rietveld 408576698