Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9108)

Unified Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h

Issue 284223004: List cloud devices in chrome://devices page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h
diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h
index a9f35d36ab4f4441117b950b7cdb9282ab11a0db..cb52e471e468460bdf67d8028c4324a33743dec4 100644
--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h
+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h
@@ -11,6 +11,7 @@
#include "base/cancelable_callback.h"
#include "base/prefs/pref_member.h"
+#include "chrome/browser/local_discovery/cloud_device_list.h"
#include "chrome/browser/local_discovery/cloud_print_printer_list.h"
#include "chrome/browser/local_discovery/privet_device_lister.h"
#include "chrome/browser/local_discovery/privet_http.h"
@@ -35,7 +36,7 @@ class ServiceDiscoverySharedClient;
class LocalDiscoveryUIHandler : public content::WebUIMessageHandler,
public PrivetRegisterOperation::Delegate,
public PrivetDeviceLister::Delegate,
- public CloudPrintPrinterList::Delegate,
+ public CloudDeviceListDelegate,
public SigninManagerBase::Observer {
public:
LocalDiscoveryUIHandler();
@@ -72,10 +73,9 @@ class LocalDiscoveryUIHandler : public content::WebUIMessageHandler,
virtual void DeviceCacheFlushed() OVERRIDE;
- // CloudPrintPrinterList::Delegate implementation.
- virtual void OnCloudPrintPrinterListReady() OVERRIDE;
-
- virtual void OnCloudPrintPrinterListUnavailable() OVERRIDE;
+ // CloudDeviceListDelegate implementation.
+ virtual void OnDeviceListReady() OVERRIDE;
+ virtual void OnDeviceListUnavailable() OVERRIDE;
// SigninManagerBase::Observer implementation.
virtual void GoogleSigninSucceeded(const std::string& username,
@@ -96,11 +96,11 @@ class LocalDiscoveryUIHandler : public content::WebUIMessageHandler,
// For when a user choice is made.
void HandleRegisterDevice(const base::ListValue* args);
- // For when a cancelation is made.
+ // For when a cancellation is made.
void HandleCancelRegistration(const base::ListValue* args);
- // For requesting the printer list.
- void HandleRequestPrinterList(const base::ListValue* args);
+ // For requesting the device list.
+ void HandleRequestDeviceList(const base::ListValue* args);
// For opening URLs (relative to the Google Cloud Print base URL) in a new
// tab.
@@ -133,9 +133,6 @@ class LocalDiscoveryUIHandler : public content::WebUIMessageHandler,
// Reset and cancel the current registration.
void ResetCurrentRegistration();
- scoped_ptr<base::DictionaryValue> CreatePrinterInfo(
- const CloudPrintPrinterList::PrinterDetails& description);
-
// Announcement hasn't been sent for a certain time after registration
// finished. Consider it failed.
// TODO(noamsml): Re-resolve service first.
@@ -143,6 +140,8 @@ class LocalDiscoveryUIHandler : public content::WebUIMessageHandler,
void CheckUserLoggedIn();
+ void CheckListingDone();
+
#if defined(CLOUD_PRINT_CONNECTOR_UI_AVAILABLE)
void StartCloudPrintConnector();
void OnCloudPrintPrefsChanged();
@@ -182,6 +181,9 @@ class LocalDiscoveryUIHandler : public content::WebUIMessageHandler,
// List of printers from cloud print.
scoped_ptr<CloudPrintPrinterList> cloud_print_printer_list_;
+ scoped_ptr<CloudDeviceList> cloud_device_list_;
+ int failed_list_count_;
+ int succeded_list_count_;
#if defined(CLOUD_PRINT_CONNECTOR_UI_AVAILABLE)
StringPrefMember cloud_print_connector_email_;

Powered by Google App Engine
This is Rietveld 408576698