Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2842203002
Cr-Commit-Position: refs/heads/master@{#468079}
Committed: https://chromium.googlesource.com/chromium/src/+/cff98375334e29507d061fd93d4e9146c785f43f

[wjmaclean, 2017-04-26 16:07:26]

Description was changed from

==========
Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
==========

to

==========
Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2017-04-26 16:07:48]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 16:08:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2017-04-26 16:54:23]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 16:54:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 18:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:19:37]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2017-04-27 14:34:39]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[wjmaclean, 2017-04-27 14:34:49]

Description was changed from

==========
Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2017-04-27 14:34:49]

wjmaclean@chromium.org changed reviewers:
+ kenrb@chromium.org

[wjmaclean, 2017-04-27 14:35:02]

kenrb@ - does this look ok?

[commit-bot: I haz the power, 2017-04-27 14:35:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 15:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 15:47:55]

Dry run: This issue passed the CQ dry run.

[kenrb, 2017-04-27 20:47:23]

lgtm with a couple of nits.

https://codereview.chromium.org/2842203002/diff/40001/content/browser/site_pe...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2842203002/diff/40001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:1124:
IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
This test should have a description.

https://codereview.chromium.org/2842203002/diff/40001/content/browser/site_pe...
content/browser/site_per_process_browsertest.cc:1185:
gesture_fling_start_ack_observer->Wait();
Since there are no EXPECT statements in the later part of this test, this should
have an explanation in comments (i.e. timeout implies a test failure).

[wjmaclean, 2017-04-28 13:06:15]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org

[wjmaclean, 2017-04-28 13:06:40]

creis@ - I've addressed kenrb@'s comments, please take a look?

[wjmaclean, 2017-04-28 13:06:54]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 13:07:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:04:50]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2017-04-28 18:17:09]

Thanks, LGTM.

[wjmaclean, 2017-04-28 18:41:15]

The CQ bit was checked by wjmaclean@chromium.org

[wjmaclean, 2017-04-28 18:41:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/2842203002/#ps60001
(title: "Add test descriptions, comment.")

[commit-bot: I haz the power, 2017-04-28 18:42:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 18:57:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493404875699730,
"parent_rev": "63901da067e069e298595618e01c4758c7896ff5", "commit_rev":
"cff98375334e29507d061fd93d4e9146c785f43f"}

[commit-bot: I haz the power, 2017-04-28 18:57:18]

Description was changed from

==========
Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Forward GestureFlingStart in OOPIF, re-enable DCHECK.

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2842203002
Cr-Commit-Position: refs/heads/master@{#468079}
Committed:
https://chromium.googlesource.com/chromium/src/+/cff98375334e29507d061fd93d4e...
==========

[commit-bot: I haz the power, 2017-04-28 18:57:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cff98375334e29507d061fd93d4e...