Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2842163005: Download Notifications : Fixed a crash (Closed)

Created:
3 years, 8 months ago by shaktisahu
Modified:
3 years, 8 months ago
Reviewers:
qinmin
CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Download Notifications : Fixed a crash Tapping on a download notification after chrome has been killed leads to a crash. This is because we are trying to access the native part of DownloadManagerService before the native has been loaded. This CL fixes the crash by adding a check for existence of the DownloadManagerService object before accessing it. BUG=715442 Review-Url: https://codereview.chromium.org/2842163005 Cr-Commit-Position: refs/heads/master@{#467460} Committed: https://chromium.googlesource.com/chromium/src/+/96216ffca1555b05e3f42c359966d6181e6467c9

Patch Set 1 : Fixed a crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
shaktisahu
PTAL
3 years, 8 months ago (2017-04-26 19:47:07 UTC) #3
qinmin
lgtm
3 years, 8 months ago (2017-04-26 19:48:18 UTC) #5
qinmin
lgtm
3 years, 8 months ago (2017-04-26 19:48:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842163005/20001
3 years, 8 months ago (2017-04-26 21:10:13 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 21:22:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96216ffca1555b05e3f42c359966...

Powered by Google App Engine
This is Rietveld 408576698