Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2842163003: Use mojo.common.mojom.FilePath to represent file paths (Closed)

Created:
3 years, 8 months ago by ftirelo
Modified:
3 years, 7 months ago
Reviewers:
Joe Mason, Will Harris
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use mojo.common.mojom.FilePath to represent file paths BUG=690020 Review-Url: https://codereview.chromium.org/2842163003 Cr-Commit-Position: refs/heads/master@{#467812} Committed: https://chromium.googlesource.com/chromium/src/+/0b6049cb383da885119055f499d26ff50d78a37c

Patch Set 1 #

Patch Set 2 : Use mojo.common.mojom.FilePath to represent file paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M components/chrome_cleaner/public/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/chrome_cleaner/public/interfaces/chrome_prompt.mojom View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
ftirelo
3 years, 8 months ago (2017-04-26 14:19:14 UTC) #2
Joe Mason
lgtm
3 years, 8 months ago (2017-04-26 14:33:14 UTC) #3
Will Harris
lgtm
3 years, 7 months ago (2017-04-27 17:02:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842163003/1
3 years, 7 months ago (2017-04-27 17:03:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/258001) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-04-27 17:21:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842163003/1
3 years, 7 months ago (2017-04-27 19:37:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/62781)
3 years, 7 months ago (2017-04-27 20:15:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842163003/20001
3 years, 7 months ago (2017-04-27 21:09:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842163003/20001
3 years, 7 months ago (2017-04-28 01:34:00 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 01:46:59 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0b6049cb383da885119055f499d2...

Powered by Google App Engine
This is Rietveld 408576698