Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2842163002: Restart browser after Chromad enrollment (Closed)

Created:
3 years, 8 months ago by Thiemo Nagel
Modified:
3 years, 7 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Roman Sorokin (ftl)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restart browser after Chromad enrollment The current factoring of BrowserPolicyConnectorChromeOS only allows to swap out the device policy provider at initialization time, not at run time. As a consequence, we end up with the wrong device policy provider after Chromad enrollment. A browser restart is the easiest way to fix this. BUG=681817 Review-Url: https://codereview.chromium.org/2842163002 Cr-Commit-Position: refs/heads/master@{#468592} Committed: https://chromium.googlesource.com/chromium/src/+/ac371d7a8f048986b667636aba153714157dc4e0

Patch Set 1 : Restart browser after Chromad enrollment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Thiemo Nagel
Hi Sasha, may I ask you to take a look at this CL? Thank you ...
3 years, 8 months ago (2017-04-26 14:21:23 UTC) #7
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-01 20:49:44 UTC) #10
Thiemo Nagel
On 2017/05/01 20:49:44, Alexander Alekseev wrote: > lgtm Thank you! Thiemo
3 years, 7 months ago (2017-05-02 09:35:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842163002/20001
3 years, 7 months ago (2017-05-02 09:35:16 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 10:03:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac371d7a8f048986b667636aba15...

Powered by Google App Engine
This is Rietveld 408576698