Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2842123003: Refactor LayoutTableCell::Has(Start|End)BorderAdjoinjingTable() and add test (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
wkorman
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor LayoutTableCell::Has(Start|End)BorderAdjoinjingTable() and add test This is a preparation of collapsed border optimization (https://codereview.chromium.org/2805103003/) and bug fixing (later). BUG=626748 Review-Url: https://codereview.chromium.org/2842123003 Cr-Commit-Position: refs/heads/master@{#467516} Committed: https://chromium.googlesource.com/chromium/src/+/aa7d0c4d11c57a4a26a2e0a18fa1a23d60be7117

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -78 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +12 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp View 1 2 chunks +134 lines, -62 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
Xianzhu
3 years, 8 months ago (2017-04-26 17:14:47 UTC) #9
wkorman
lgtm
3 years, 8 months ago (2017-04-26 23:25:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842123003/20001
3 years, 8 months ago (2017-04-26 23:37:32 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 23:46:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aa7d0c4d11c57a4a26a2e0a18fa1...

Powered by Google App Engine
This is Rietveld 408576698