Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2842083002: Report Login.SuccessReason in LoginPerformer (Closed)

Created:
3 years, 8 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 8 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, oshima+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Report Login.SuccessReason in LoginPerformer Login.SuccessReason already exists in histograms.xml but was not used. Do not report offline and online login success separately as I think it's unnecessary. BUG=175906 Review-Url: https://codereview.chromium.org/2842083002 Cr-Commit-Position: refs/heads/master@{#467194} Committed: https://chromium.googlesource.com/chromium/src/+/187f69b644f33ff3dbec23972e3b18dcc1222930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chromeos/login/auth/auth_status_consumer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chromeos/login/auth/login_performer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Wenzhao (Colin) Zang
3 years, 8 months ago (2017-04-26 00:26:48 UTC) #3
Alexander Alekseev
lgtm
3 years, 8 months ago (2017-04-26 00:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842083002/1
3 years, 8 months ago (2017-04-26 00:39:51 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 01:20:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/187f69b644f33ff3dbec23972e3b...

Powered by Google App Engine
This is Rietveld 408576698