Handle error in connector and close handle and swap with dummy handle.

Handle error in connector.
Close handle and swap with dummy handle when read.result !== core.RESULT_FAILED_PRECONDITION.

BUG=716959
Review-Url: https://codereview.chromium.org/2842073003
Cr-Commit-Position: refs/heads/master@{#470069}
Committed: https://chromium.googlesource.com/chromium/src/+/b3d75e896a9c8316dede96ed1ee608cce40d43ab

[wangjimmy, 2017-04-26 01:32:41]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 01:33:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 02:17:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wangjimmy, 2017-04-27 05:05:04]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 05:05:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 06:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 06:16:28]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-04-28 23:13:40]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:14:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-28 23:21:00]

The CQ bit was unchecked by wangjimmy@chromium.org

[wangjimmy, 2017-04-28 23:31:34]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[wangjimmy, 2017-04-28 23:32:14]

The CQ bit was unchecked by wangjimmy@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:32:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-28 23:47:33]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:48:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 00:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 00:30:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wangjimmy, 2017-04-29 03:00:48]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 03:01:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 03:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 03:59:19]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-05-01 04:02:15]

Description was changed from

==========
Handle error in connector and close handle and swap with dummy handle.

BUG=
==========

to

==========
Handle error in connector. Close handle and swap with dummy handle when
read.result !== core.RESULT_FAILED_PRECONDITION.

BUG=716959
==========

[wangjimmy, 2017-05-01 04:02:36]

Description was changed from

==========
Handle error in connector. Close handle and swap with dummy handle when
read.result !== core.RESULT_FAILED_PRECONDITION.

BUG=716959
==========

to

==========
Handle error in connector.
Close handle and swap with dummy handle when read.result !==
core.RESULT_FAILED_PRECONDITION.

BUG=716959
==========

[wangjimmy, 2017-05-01 04:09:05]

wangjimmy@chromium.org changed reviewers:
+ yzshen@chromium.org

[wangjimmy, 2017-05-01 04:09:06]

Hi Yuzhu, PTAL at all. Thank you

[yzshen1, 2017-05-02 22:29:21]

https://codereview.chromium.org/2842073003/diff/120001/mojo/public/js/connect...
File mojo/public/js/connector.js (right):

https://codereview.chromium.org/2842073003/diff/120001/mojo/public/js/connect...
mojo/public/js/connector.js:143: forceAsyncHandler) {
nit: please align "forceAsyncHandler" with "forcePipeReset" on the previous
line.

https://codereview.chromium.org/2842073003/diff/120001/mojo/public/js/connect...
mojo/public/js/connector.js:144: if (this.error_) {
Does it make sense to also early return when this.handle_ is null?

[wangjimmy, 2017-05-04 00:37:28]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 00:37:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 01:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 01:42:59]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-05-04 03:12:38]

https://codereview.chromium.org/2842073003/diff/120001/mojo/public/js/connect...
File mojo/public/js/connector.js (right):

https://codereview.chromium.org/2842073003/diff/120001/mojo/public/js/connect...
mojo/public/js/connector.js:143: forceAsyncHandler) {
On 2017/05/02 22:29:20, yzshen1 wrote:
> nit: please align "forceAsyncHandler" with "forcePipeReset" on the previous
> line.

Done.

https://codereview.chromium.org/2842073003/diff/120001/mojo/public/js/connect...
mojo/public/js/connector.js:144: if (this.error_) {
On 2017/05/02 22:29:20, yzshen1 wrote:
> Does it make sense to also early return when this.handle_ is null?

Fixed, added early return.

Yes, because even though |readMore_()| calls handleError
support.watch(this.handle_,  core.HANDLE_SIGNAL_READABLE,
this.readMore_.bind(this));
When this.handle_ becomes null, the watcher no longer triggers the the
|readMore()| callback.

There is another caller of handleError which is for the cachedMessage case in
Router. So we need to early return in this case if this.handle_ is null.

[yzshen1, 2017-05-04 22:15:42]

lgtm

[wangjimmy, 2017-05-05 14:51:36]

The CQ bit was checked by wangjimmy@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:52:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 14:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:52:03]

The author wangjimmy@chromium.org has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[yzshen1, 2017-05-05 16:51:32]

On 2017/05/05 14:52:03, commit-bot: I haz the power wrote:
> The author mailto:wangjimmy@chromium.org has not signed Google Contributor
License
> Agreement. Please visit https://cla.developers.google.com to sign and manage
> CLA.

Jimmy.

I guess you need to sign the agreement now that your intership has ended?
If you don't feel like to do it, I could take over the CL and land it for you.
Please let me know.

Thanks!

[wangjimmy, 2017-05-08 15:57:58]

The CQ bit was checked by wangjimmy@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:58:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 15:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:58:25]

The author wangjimmy@chromium.org has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[wangjimmy, 2017-05-08 16:01:08]

The CQ bit was checked by wangjimmy@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:18:22]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[wangjimmy, 2017-05-08 18:03:48]

The CQ bit was checked by wangjimmy@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:05:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:00:31]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1494266628588610,
"parent_rev": "5ef672aa5ffed4146ede2c1d22a04fb91dd5f168", "commit_rev":
"b3d75e896a9c8316dede96ed1ee608cce40d43ab"}

[commit-bot: I haz the power, 2017-05-08 19:01:02]

Description was changed from

==========
Handle error in connector.
Close handle and swap with dummy handle when read.result !==
core.RESULT_FAILED_PRECONDITION.

BUG=716959
==========

to

==========
Handle error in connector.
Close handle and swap with dummy handle when read.result !==
core.RESULT_FAILED_PRECONDITION.

BUG=716959

Review-Url: https://codereview.chromium.org/2842073003
Cr-Commit-Position: refs/heads/master@{#470069}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3d75e896a9c8316dede96ed1ee6...
==========

[commit-bot: I haz the power, 2017-05-08 19:01:06]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b3d75e896a9c8316dede96ed1ee6...