Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2842033002: Linux sandbox: handle ENOSPC clone failure (Closed)

Created:
2 years, 6 months ago by Tom (Use chromium acct)
Modified:
2 years, 6 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, jln+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: handle ENOSPC clone failure Linux 4.9 adds /proc/sys/user/max_user_namespaces to limit the number of concurrent user namespaces. Sometimes the limit is set to 0 in which case clone() will return ENOSPC. This CL avoids PCHECK()ing in that case. BUG=715138 R=mdempsky@chromium.org Review-Url: https://codereview.chromium.org/2842033002 Cr-Commit-Position: refs/heads/master@{#467271} Committed: https://chromium.googlesource.com/chromium/src/+/aebec0b4680564dfd5184cb288c07a2fd0ca50bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M sandbox/linux/services/credentials.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom (Use chromium acct)
mdempsky ptal
2 years, 6 months ago (2017-04-25 21:59:43 UTC) #1
mdempsky
lgtm
2 years, 6 months ago (2017-04-26 06:56:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842033002/1
2 years, 6 months ago (2017-04-26 08:02:28 UTC) #4
commit-bot: I haz the power
2 years, 6 months ago (2017-04-26 08:50:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aebec0b4680564dfd5184cb288c0...

Powered by Google App Engine
This is Rietveld 408576698