Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2842023003: fix a layout test crash due to no browser window (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

fix a layout test crash due to no browser window The test opens a link to a pdf, which results in a download and closing the tab immediately. As a result, the crash could triggered by potential race between shut down the content shell and opening the download. BUG=707599 Review-Url: https://codereview.chromium.org/2842023003 Cr-Commit-Position: refs/heads/master@{#467392} Committed: https://chromium.googlesource.com/chromium/src/+/58a9ac7a9f534ef3cda229da75cff9e6f6487a24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/shell/browser/layout_test/layout_test_download_manager_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
qinmin
3 years, 7 months ago (2017-04-25 22:19:14 UTC) #2
qinmin
PTAL
3 years, 7 months ago (2017-04-25 22:19:23 UTC) #3
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-04-25 23:31:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842023003/1
3 years, 7 months ago (2017-04-25 23:52:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/420332)
3 years, 7 months ago (2017-04-26 00:03:29 UTC) #8
qinmin
+mkwst@ for OWNER
3 years, 7 months ago (2017-04-26 17:41:15 UTC) #10
Mike West
lgtm
3 years, 7 months ago (2017-04-26 17:43:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842023003/1
3 years, 7 months ago (2017-04-26 18:35:37 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 18:46:22 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58a9ac7a9f534ef3cda229da75cf...

Powered by Google App Engine
This is Rietveld 408576698