Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2842023002: Refactor VR e2e tests (Closed)

Created:
3 years, 8 months ago by bsheedy
Modified:
3 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor VR e2e tests Moves the WebVR test framework out of WebVrTest.java into a new VrTestBase.java that WebVrTest and VrShellTest both extend instead of ChromeTabbedActivityTestBase. This is because some VrShell tests in the future will need to test WebVR as well, such as testing presentation while in the VR browser. BUG=715663 Review-Url: https://codereview.chromium.org/2842023002 Cr-Commit-Position: refs/heads/master@{#467468} Committed: https://chromium.googlesource.com/chromium/src/+/657dc245082eca1a149709f877f85e5e135996ea

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -200 lines) Patch
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java View 2 chunks +4 lines, -3 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java View 1 chunk +212 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java View 1 2 chunks +3 lines, -197 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bsheedy
+nyquist@ for chrome/android and chrome/android/javatests OWNERS. Lots of lines changed, but no real changes besides ...
3 years, 8 months ago (2017-04-25 19:51:32 UTC) #2
nyquist
lgtm
3 years, 8 months ago (2017-04-26 20:56:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842023002/20001
3 years, 8 months ago (2017-04-26 21:38:37 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 21:46:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/657dc245082eca1a149709f877f8...

Powered by Google App Engine
This is Rietveld 408576698