Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2841943005: Create TaskScheduler in WebMainLoop constructor. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create TaskScheduler in WebMainLoop constructor. This CL allows tasks to be posted via base/task_scheduler/post_task.h as soon as WebMainLoop is instantiated. Tasks don't run until TaskScheduler::Start() is called in BrowserMainLoop::CreateThreads(). This change matches a BrowserMainLoop change: https://codereview.chromium.org/2835933004/ BUG=690706 Review-Url: https://codereview.chromium.org/2841943005 Cr-Commit-Position: refs/heads/master@{#467439} Committed: https://chromium.googlesource.com/chromium/src/+/70f501b9dc3cd0ed78e99ec63514700c31186666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M ios/web/app/web_main_loop.mm View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fdoray
PTAL
3 years, 7 months ago (2017-04-26 19:25:49 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 7 months ago (2017-04-26 20:18:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841943005/1
3 years, 7 months ago (2017-04-26 20:23:02 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 20:30:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/70f501b9dc3cd0ed78e99ec63514...

Powered by Google App Engine
This is Rietveld 408576698