Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2841943003:
bluetooth: Use BuildInfo to retrieve the Android version (Closed)
Descriptionbluetooth: Use BuildInfo to retrieve the Android version
__ANDROID_API__ is the minimum API supported by the NDK we are compiling
against, not the API level of the device we are running on. Because we
support 16+ we were always returning false.
BUG=714623
Review-Url: https://codereview.chromium.org/2841943003
Cr-Commit-Position: refs/heads/master@{#467319}
Committed: https://chromium.googlesource.com/chromium/src/+/c71286bf4ad5a3a4cf1a031fe100f26664c8a023
Patch Set 1 #Patch Set 2 : bluetooth: Use BuildInfo to retrieve the Android version #Messages
Total messages: 18 (14 generated)
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== bluetooth: IsLowEnergySupported temporarily returns true for Android __ANDROID_API__ returns "16" even on Marshamallow. Until we figure out a better way to get the Android version we always return true. The only effect of this change is that Web Bluetooth will reject requestDevice calls with "Bluetooth Adapter not present." instead of rejecting promises with "Bluetooth Low Energy not available." on Android < 23. There should be no changes to Android >= 23 devices. BUG=714623 ========== to ========== bluetooth: IsLowEnergySupported temporarily returns true for Android __ANDROID_API__ returns "16" even on Marshamallow. Until we figure out a better way to get the Android version we always return true. See http://crbug.com/715384 for follow up work. The only effect of this change is that Web Bluetooth will reject requestDevice calls with "Bluetooth Adapter not present." instead of rejecting promises with "Bluetooth Low Energy not available." on Android < 23. There should be no changes to Android >= 23 devices. BUG=714623 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
ortuno@chromium.org changed reviewers: + scheib@chromium.org
scheib: PTAL. Feel free to CQ if it looks good to you.
Description was changed from ========== bluetooth: IsLowEnergySupported temporarily returns true for Android __ANDROID_API__ returns "16" even on Marshamallow. Until we figure out a better way to get the Android version we always return true. See http://crbug.com/715384 for follow up work. The only effect of this change is that Web Bluetooth will reject requestDevice calls with "Bluetooth Adapter not present." instead of rejecting promises with "Bluetooth Low Energy not available." on Android < 23. There should be no changes to Android >= 23 devices. BUG=714623 ========== to ========== bluetooth: Use BuildInfo to retrieve the Android version __ANDROID_API__ is the minimum API supported by the NDK we are compiling against, not the API level of the device we are running on. Because we support 16+ we were always returning false. BUG=714623 ==========
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scheib@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493216030048350,
"parent_rev": "b8d34ab3bfbbc9cd34d48a72bad3fdb0ea5507b4", "commit_rev":
"c71286bf4ad5a3a4cf1a031fe100f26664c8a023"}
Message was sent while issue was closed.
Description was changed from ========== bluetooth: Use BuildInfo to retrieve the Android version __ANDROID_API__ is the minimum API supported by the NDK we are compiling against, not the API level of the device we are running on. Because we support 16+ we were always returning false. BUG=714623 ========== to ========== bluetooth: Use BuildInfo to retrieve the Android version __ANDROID_API__ is the minimum API supported by the NDK we are compiling against, not the API level of the device we are running on. Because we support 16+ we were always returning false. BUG=714623 Review-Url: https://codereview.chromium.org/2841943003 Cr-Commit-Position: refs/heads/master@{#467319} Committed: https://chromium.googlesource.com/chromium/src/+/c71286bf4ad5a3a4cf1a031fe100... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c71286bf4ad5a3a4cf1a031fe100... |
