Issue 284193006: Revert 270894 "Use real PlatformSupport in content unit tests"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284193006: Revert 270894 "Use real PlatformSupport in content unit tests" (Closed)

Created:
6 years, 7 months ago by benwells

Modified:
6 years, 7 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 270894 "Use real PlatformSupport in content unit tests" > Use real PlatformSupport in content unit tests > > Once all pages are force composited by default, this allows these tests > to not explode when trying to create GraphicsLayers because of a lack of > Platform::compositorSupport. > > BUG=none > > Review URL: https://codereview.chromium.org/287043002 This test has caused leak errors on the mac valgrind bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/27964 TBR=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270950

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -18 lines)			Patch
M	trunk/src/content/content_tests.gypi	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	trunk/src/content/public/test/unittest_test_suite.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/public/test/unittest_test_suite.cc	View	1 chunk	+26 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r270950.