Use real PlatformSupport in content unit tests

Use real PlatformSupport in content unit tests

Once all pages are force composited by default, this allows these tests
to not explode when trying to create GraphicsLayers because of a lack of
Platform::compositorSupport.

BUG=361729
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271794

[piman, 2014-05-15 19:46:57]

lgtm

[enne (OOO), 2014-05-15 19:49:13]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2014-05-15 19:49:28]

The CQ bit was unchecked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-15 19:49:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/287043002/10001

[enne (OOO), 2014-05-15 19:50:23]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-15 19:50:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/287043002/30001

[enne (OOO), 2014-05-15 21:49:31]

piman: I'm no gyp expert, but I think this is the right thing to do, so you may
want to take a second look.

Because unittest_test_suite (in the test_support_content target) now depends on
TestWebKitPlatformSupport (in content_webkit_unit_test_support target) this
created a cycle between these two targets since the latter already depended on
the former.  I collapsed them together, but can't remove the mostly useless
target yet until it's not used in Blink.

[piman, 2014-05-15 21:56:43]

https://codereview.chromium.org/287043002/diff/50001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/287043002/diff/50001/content/content_tests.gy...
content/content_tests.gypi:217: 'test/web_layer_tree_view_impl_for_testing.h',
I suspect some of these will need to be excluded on ios.

https://codereview.chromium.org/287043002/diff/50001/content/content_tests.gy...
content/content_tests.gypi:1363: 'type': 'static_library',
Would 'none' work? I'm not sure what an empty static_library will do.

[piman, 2014-05-15 22:00:44]

(LGTM whatever works)

[enne (OOO), 2014-05-15 22:10:42]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-15 22:12:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/287043002/60001

[commit-bot: I haz the power, 2014-05-16 01:11:07]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-16 01:35:27]

Change committed as 270894

[enne (OOO), 2014-05-16 17:14:27]

Reverted in https://codereview.chromium.org/284193006/for memory leaks.  I'll
look into it.

[enne (OOO), 2014-05-16 21:11:03]

Apparently it's impossible to run a try job to make mac_valgrind run the "memory
test: content" step.  benwells suggests just relanding this and seeing if this
fixes the issue.  If this second patch rolled out, I'll go dig up a mac and
verify locally.

[enne (OOO), 2014-05-16 21:11:07]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-16 21:12:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/287043002/80001

[commit-bot: I haz the power, 2014-05-17 06:45:11]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-17 16:58:26]

Change committed as 271229

[enne (OOO), 2014-05-17 20:12:27]

A revert of this CL has been created in
https://codereview.chromium.org/290303002/ by enne@chromium.org.

The reason for reverting is: Caused mac_valgrind issues because
TestWebKitPlatformSupport isn't cleaning up after itself properly.

[benwells, 2014-05-19 07:18:44]

On 2014/05/17 20:12:27, enne wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/290303002/ by mailto:enne@chromium.org.
> 
> The reason for reverting is: Caused mac_valgrind issues because
> TestWebKitPlatformSupport isn't cleaning up after itself properly.


We can add suppressions for the leaks if they are unavoidable, but it seems
strange that we would need to. Does you destructor get called in practice?

[enne (OOO), 2014-05-20 18:56:51]

+thestig for memory suppressions

On 2014/05/19 07:18:44, benwells wrote:
> On 2014/05/17 20:12:27, enne wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/290303002/ by mailto:enne@chromium.org.
> > 
> > The reason for reverting is: Caused mac_valgrind issues because
> > TestWebKitPlatformSupport isn't cleaning up after itself properly.
> 
> 
> We can add suppressions for the leaks if they are unavoidable, but it seems
> strange that we would need to. Does you destructor get called in practice?

Yeah, the destructor gets called in practice.  There would be other leaks if
that were not so, since it allocates a number of scoped members in the
constructor.  The only thing I can think of is that maybe because they are all
NSallocated objects that maybe the destructor happens too late with respect to
the NS scoped pool inside of the unit test Run function.  However, that's a wild
guess as I have very little Mac expertise.

[Lei Zhang, 2014-05-20 18:59:56]

On 2014/05/20 18:56:51, enne wrote:
> +thestig for memory suppressions
> 

They should go in suppressions_mac.txt, otherwise LGTM

[enne (OOO), 2014-05-20 19:11:28]

On 2014/05/20 18:59:56, Lei Zhang wrote:
> On 2014/05/20 18:56:51, enne wrote:
> > +thestig for memory suppressions
> > 
> 
> They should go in suppressions_mac.txt, otherwise LGTM

Thanks, done.

[enne (OOO), 2014-05-20 19:12:21]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-20 19:12:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/287043002/120001

[commit-bot: I haz the power, 2014-05-21 01:39:20]

Change committed as 271794