Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2841923002: Remove unused "using" statements in WebKit/Source/platform. (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 7 months ago
Reviewers:
Mike West
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused "using" statements in WebKit/Source/platform. Some "using" statements that were no longer used lingered in the source code so let us remove them. Review-Url: https://codereview.chromium.org/2841923002 Cr-Commit-Position: refs/heads/master@{#467654} Committed: https://chromium.googlesource.com/chromium/src/+/fb30cf0a0e61cfaf953ed2347ddfa876d139d1eb

Patch Set 1 #

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/Length.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataCache.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Daniel Bratell
Hi, can you take a look at this patch that removes unused "using" statements from ...
3 years, 8 months ago (2017-04-27 09:20:14 UTC) #10
Mike West
Less `using` is better `using`! LGTM.
3 years, 7 months ago (2017-04-27 11:08:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841923002/20001
3 years, 7 months ago (2017-04-27 11:16:37 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 13:19:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb30cf0a0e61cfaf953ed2347ddf...

Powered by Google App Engine
This is Rietveld 408576698