WebUI: Move all test related WebUI GN targets to their own file.

WebUI: Move all test related WebUI GN targets to their own file.

Currently all WebUI test targets are residing within the very large
(5000+ LOC) chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests.
This makes simple tasks unnecessarily hard.

For example attempting to limit all WebUI tests to not run on a certain
platform/configuration (e.g MSAN/ASAN/TSAN), is tedious and fragile because
one needs to identify WebUI tests spread across a 5k LOC file.

BUG=NONE

Review-Url: https://codereview.chromium.org/2841863004
Cr-Commit-Position: refs/heads/master@{#467361}
Committed: https://chromium.googlesource.com/chromium/src/+/1b41aa953d0fc0b3c6561b7ba15364f368b1a7c7

[dpapad, 2017-04-25 23:03:51]

Description was changed from

==========
WebUI: Move all WebUI related tests BUILD config into their own file.

BUG=
==========

to

==========
WebUI: Move all WebUI test related BUILD config into their own file.

Currently all WebUI tests were residing within the very large
chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests, which makes
simple tasks fairly hard.

For example attempting to limit all WebUI tests to not run on any MSAN/ASAN/TSAN
bots was hard, just because of having to tell which tests in
chrome/test/BUILD.gn
should be affected.

BUG=NONE
==========

[dpapad, 2017-04-25 23:04:18]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 23:04:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 23:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 23:25:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2017-04-25 23:44:37]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 23:45:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:06:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2017-04-26 00:28:00]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 00:28:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-26 01:03:20]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 01:03:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-26 01:24:02]

Description was changed from

==========
WebUI: Move all WebUI test related BUILD config into their own file.

Currently all WebUI tests were residing within the very large
chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests, which makes
simple tasks fairly hard.

For example attempting to limit all WebUI tests to not run on any MSAN/ASAN/TSAN
bots was hard, just because of having to tell which tests in
chrome/test/BUILD.gn
should be affected.

BUG=NONE
==========

to

==========
WebUI: Move all test related WebUI GN targets to their own file.

Currently all WebUI test targets are residing within the very large
(5000+ LOC) chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests.
This makes simple tasks unnecessarily hard.

For example attempting to limit all WebUI tests to not run on a certain
platform/configuration (e.g MSAN/ASAN/TSAN), is tedious and fragile because
one needs to identify WebUI tests spread across a 5k lOC file.

BUG=NONE
==========

[dpapad, 2017-04-26 01:25:20]

Description was changed from

==========
WebUI: Move all test related WebUI GN targets to their own file.

Currently all WebUI test targets are residing within the very large
(5000+ LOC) chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests.
This makes simple tasks unnecessarily hard.

For example attempting to limit all WebUI tests to not run on a certain
platform/configuration (e.g MSAN/ASAN/TSAN), is tedious and fragile because
one needs to identify WebUI tests spread across a 5k lOC file.

BUG=NONE
==========

to

==========
WebUI: Move all test related WebUI GN targets to their own file.

Currently all WebUI test targets are residing within the very large
(5000+ LOC) chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests.
This makes simple tasks unnecessarily hard.

For example attempting to limit all WebUI tests to not run on a certain
platform/configuration (e.g MSAN/ASAN/TSAN), is tedious and fragile because
one needs to identify WebUI tests spread across a 5k LOC file.

BUG=NONE
==========

[dpapad, 2017-04-26 02:19:04]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org, sky@chromium.org

[commit-bot: I haz the power, 2017-04-26 02:40:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 02:40:49]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-26 15:16:46]

LGTM

[sky, 2017-04-26 15:18:25]

Meta comment (not to stop you landing). I find it very unusual that there are
actual tests in the data directory. I would not expect that.

[Dan Beam, 2017-04-26 15:43:52]

On 2017/04/26 15:18:25, sky wrote:
> Meta comment (not to stop you landing). I find it very unusual that there are
> actual tests in the data directory. I would not expect that.

you would be surprised how often our (web) code is considered "data" by others
;)

for many many years, no web code was considered "source code" by various tools
(i.e. presubmits).  i still don't think .html files are (and therefore most
don't have licenses).

and yes, we have a ton of tests in chrome/test/data/ because ... ¯\_(ツ)_/¯
(likely somebody slapped a bunch of benchmarks or training data here that also
used web technologies and somebody else figured that's where web-y tests go).

[Dan Beam, 2017-04-26 15:45:11]

lgtm i'd be happy to find a new directory for these eventually, though (agree
with sky@ that continuing to keep them in a /data/ dir is going to be
counter-intuitive).

[dpapad, 2017-04-26 17:16:29]

On 2017/04/26 at 15:45:11, dbeam wrote:
> lgtm i'd be happy to find a new directory for these eventually, though (agree
with sky@ that continuing to keep them in a /data/ dir is going to be
counter-intuitive).

Thanks. I also agree that some other directory other than data/ might be more
appropriate.

[dpapad, 2017-04-26 17:16:32]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-26 17:17:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:22:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493226992292820,
"parent_rev": "dd5c8367dd3a9c73ca1c0338d613d8540d7f22c0", "commit_rev":
"1b41aa953d0fc0b3c6561b7ba15364f368b1a7c7"}

[commit-bot: I haz the power, 2017-04-26 17:23:03]

Description was changed from

==========
WebUI: Move all test related WebUI GN targets to their own file.

Currently all WebUI test targets are residing within the very large
(5000+ LOC) chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests.
This makes simple tasks unnecessarily hard.

For example attempting to limit all WebUI tests to not run on a certain
platform/configuration (e.g MSAN/ASAN/TSAN), is tedious and fragile because
one needs to identify WebUI tests spread across a 5k LOC file.

BUG=NONE
==========

to

==========
WebUI: Move all test related WebUI GN targets to their own file.

Currently all WebUI test targets are residing within the very large
(5000+ LOC) chrome/test/BUILD.gn which holds both WebUI and non-WebUI tests.
This makes simple tasks unnecessarily hard.

For example attempting to limit all WebUI tests to not run on a certain
platform/configuration (e.g MSAN/ASAN/TSAN), is tedious and fragile because
one needs to identify WebUI tests spread across a 5k LOC file.

BUG=NONE

Review-Url: https://codereview.chromium.org/2841863004
Cr-Commit-Position: refs/heads/master@{#467361}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b41aa953d0fc0b3c6561b7ba153...
==========

[commit-bot: I haz the power, 2017-04-26 17:23:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1b41aa953d0fc0b3c6561b7ba153...