Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 284183014: Revert 272549 "Add test for action_runner.BeginInteraction and a..." (Closed)

Created:
6 years, 7 months ago by Michael Courage
Modified:
6 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272549 "Add test for action_runner.BeginInteraction and a..." The added test failed on Mac 10.7. > Add test for action_runner.BeginInteraction and action_runner.EndInteraction. > > BUG=368767 > > Review URL: https://codereview.chromium.org/294943006 TBR=nednguyen@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
D trunk/src/tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Courage
6 years, 7 months ago (2014-05-23 18:00:23 UTC) #1
Michael Courage
Committed patchset #1 manually as r272560.
6 years, 7 months ago (2014-05-23 18:00:44 UTC) #2
nednguyen
On 2014/05/23 18:00:44, Michael Courage wrote: > Committed patchset #1 manually as r272560. Hi Michael, ...
6 years, 7 months ago (2014-05-23 18:03:48 UTC) #3
Michael Courage
Looks like it hit these two builds http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/builds/48481 http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/27214 On Fri, May 23, 2014 at ...
6 years, 7 months ago (2014-05-23 18:04:47 UTC) #4
nednguyen
On 2014/05/23 18:03:48, nednguyen wrote: > On 2014/05/23 18:00:44, Michael Courage wrote: > > Committed ...
6 years, 7 months ago (2014-05-23 18:05:46 UTC) #5
nednguyen
On 2014/05/23 18:05:46, nednguyen wrote: > On 2014/05/23 18:03:48, nednguyen wrote: > > On 2014/05/23 ...
6 years, 7 months ago (2014-05-23 18:14:57 UTC) #6
Michael Courage
6 years, 7 months ago (2014-05-23 18:19:21 UTC) #7
Cool, thanks for the heads-up


On Fri, May 23, 2014 at 11:14 AM, <nednguyen@google.com> wrote:

> On 2014/05/23 18:05:46, nednguyen wrote:
>
>> On 2014/05/23 18:03:48, nednguyen wrote:
>> > On 2014/05/23 18:00:44, Michael Courage wrote:
>> > > Committed patchset #1 manually as r272560.
>> >
>> > Hi Michael, thanks for reverting this just in time. Do you mind giving
>> me
>>
> the
>
>> > link to bot failure to debug this?
>>
>
>  Nvm, I found the bug. Sorry for this.
>>
>
> It looks like this is caused by a the fact that r272549 is submitted when
> CQ bot
> hasn't catched up with the change in https://codereview.chromium.
> org/277143003/
> yet. I just rebase https://codereview.chromium.org/294943006 and submit it
> again.
>
> https://codereview.chromium.org/284183014/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698