Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: media/base/video_color_space.h

Issue 2841813002: Converting video color space enums to their corresponding gfx:color space eqvivalent. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/video_color_space.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_color_space.h
diff --git a/media/base/video_color_space.h b/media/base/video_color_space.h
index 59ec578e1d22715dda4f4c76d27d42679a9169dd..010707e7e0a76ad95785a96682bfc317198ebf3d 100644
--- a/media/base/video_color_space.h
+++ b/media/base/video_color_space.h
@@ -70,6 +70,21 @@ class MEDIA_EXPORT VideoColorSpace {
INVALID = 255,
};
+ union PrimaryIDUnion {
+ PrimaryID primaries;
+ uint8_t primary_id;
+ };
+
+ union TransferIDUnion {
+ TransferID transfer;
+ uint8_t transfer_id;
+ };
+
+ union MatrixIDUnion {
+ MatrixID matrix;
+ uint8_t matrix_id;
+ };
+
VideoColorSpace();
VideoColorSpace(int primaries,
int transfer,
@@ -99,6 +114,9 @@ class MEDIA_EXPORT VideoColorSpace {
PrimaryID primaries = PrimaryID::INVALID;
TransferID transfer = TransferID::INVALID;
MatrixID matrix = MatrixID::INVALID;
a.suchit2 2017/04/25 14:05:08 For the small usage of enum, we would not required
Uzair 2017/04/25 14:12:34 I am not sure about any other way without using un
a.suchit2 2017/04/25 14:45:51 Enum variables : lines 114,115,116
a.suchit2 2017/04/25 14:45:51 Enum variables : lines 114,115,116
+ PrimaryIDUnion primaries_union;
+ TransferIDUnion transfer_union;
+ MatrixIDUnion matrix_union;
gfx::ColorSpace::RangeID range = gfx::ColorSpace::RangeID::INVALID;
};
« no previous file with comments | « no previous file | media/base/video_color_space.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698