Converting video color space enums to their corresponding gfx:color space eqvivalent.

media/base/video_color_space.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_VIDEO_COLOR_SPACE_H_
 #define MEDIA_BASE_VIDEO_COLOR_SPACE_H_
 
 #include "media/base/media_export.h"
 #include "ui/gfx/color_space.h"
 
@@ skipping 52 matching lines @@
     BT470BG = 5,
     SMPTE170M = 6,
     SMPTE240M = 7,
     YCOCG = 8,
     BT2020_NCL = 9,
     BT2020_CL = 10,
     YDZDX = 11,
     INVALID = 255,
   };
 
+  union PrimaryIDUnion {
+    PrimaryID primaries;
+    uint8_t primary_id;
+  };
+
+  union TransferIDUnion {
+    TransferID transfer;
+    uint8_t transfer_id;
+  };
+
+  union MatrixIDUnion {
+    MatrixID matrix;
+    uint8_t matrix_id;
+  };
+
   VideoColorSpace();
   VideoColorSpace(int primaries,
                   int transfer,
                   int matrix,
                   gfx::ColorSpace::RangeID range);
   VideoColorSpace(PrimaryID primaries,
                   TransferID transfer,
                   MatrixID matrix,
                   gfx::ColorSpace::RangeID range);
 
   bool operator==(const VideoColorSpace& other) const;
   bool operator!=(const VideoColorSpace& other) const;
 
   // These will return INVALID if the number you give it
   // is not a valid enum value.
   static PrimaryID GetPrimaryID(int primary);
   static TransferID GetTransferID(int transfer);
   static MatrixID GetMatrixID(int matrix);
 
   static VideoColorSpace REC709();
   static VideoColorSpace REC601();
   static VideoColorSpace JPEG();
 
   gfx::ColorSpace ToGfxColorSpace() const;
 
   // Note, these are public variables.
   PrimaryID primaries = PrimaryID::INVALID;
   TransferID transfer = TransferID::INVALID;
   MatrixID matrix = MatrixID::INVALID;

[a.suchit2, 2017/04/25 14:05:08]

For the small usage of enum, we would not required union.
But if we are doing it then above 3 variables are not needed.
Please remove them.

[Uzair, 2017/04/25 14:12:34]

I am not sure about any other way without using union we can convert enum class
to int.
Please can you let me know which variables are not needed, union variables or
enum class
variables ?

[a.suchit2, 2017/04/25 14:45:51]

Enum variables : lines 114,115,116

[a.suchit2, 2017/04/25 14:45:51]

Enum variables : lines 114,115,116

+  PrimaryIDUnion primaries_union;
+  TransferIDUnion transfer_union;
+  MatrixIDUnion matrix_union;
   gfx::ColorSpace::RangeID range = gfx::ColorSpace::RangeID::INVALID;
 };
 
 }  // namespace media
 
 #endif