Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2841803003: Wire up rtc_packet_ids to P2PSocketHostTcp, which is required for correct BWE in WebRTC. (Closed)

Created:
3 years, 8 months ago by Stefan
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wire up rtc_packet_ids to P2PSocketHostTcp, which is required for correct BWE in WebRTC. BUG=chromium:715099 Review-Url: https://codereview.chromium.org/2841803003 Cr-Commit-Position: refs/heads/master@{#467349} Committed: https://chromium.googlesource.com/chromium/src/+/dabbe072b786618bbc557381a0c535596c698822

Patch Set 1 #

Total comments: 7

Patch Set 2 : Comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -33 lines) Patch
M content/browser/renderer_host/p2p/socket_host_tcp.h View 1 2 chunks +13 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 5 chunks +44 lines, -30 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.h View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Stefan
3 years, 8 months ago (2017-04-25 14:36:41 UTC) #2
Taylor_Brandstetter
Not an owner, but lgtm https://codereview.chromium.org/2841803003/diff/1/content/browser/renderer_host/p2p/socket_host_tcp.h File content/browser/renderer_host/p2p/socket_host_tcp.h (right): https://codereview.chromium.org/2841803003/diff/1/content/browser/renderer_host/p2p/socket_host_tcp.h#newcode32 content/browser/renderer_host/p2p/socket_host_tcp.h:32: public: Could add a ...
3 years, 8 months ago (2017-04-25 21:34:19 UTC) #7
Sergey Ulanov
https://codereview.chromium.org/2841803003/diff/1/content/browser/renderer_host/p2p/socket_host_tcp.h File content/browser/renderer_host/p2p/socket_host_tcp.h (right): https://codereview.chromium.org/2841803003/diff/1/content/browser/renderer_host/p2p/socket_host_tcp.h#newcode33 content/browser/renderer_host/p2p/socket_host_tcp.h:33: typedef std::pair<uint64_t, scoped_refptr<net::DrainableIOBuffer>> SendBuffer; I think it would be ...
3 years, 8 months ago (2017-04-26 00:11:52 UTC) #8
Stefan
Excellent comments. Should be addressed now! https://codereview.chromium.org/2841803003/diff/1/content/browser/renderer_host/p2p/socket_host_tcp.h File content/browser/renderer_host/p2p/socket_host_tcp.h (right): https://codereview.chromium.org/2841803003/diff/1/content/browser/renderer_host/p2p/socket_host_tcp.h#newcode32 content/browser/renderer_host/p2p/socket_host_tcp.h:32: public: On 2017/04/25 ...
3 years, 8 months ago (2017-04-26 09:02:39 UTC) #9
Taylor_Brandstetter
lgtm
3 years, 8 months ago (2017-04-26 16:44:37 UTC) #14
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-26 16:51:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841803003/20001
3 years, 8 months ago (2017-04-26 16:52:45 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 16:57:16 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dabbe072b786618bbc557381a0c5...

Powered by Google App Engine
This is Rietveld 408576698