Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2841783002: Don't uninstall Google Update for Windows Installer-driven uninstalls. (Closed)

Created:
3 years, 8 months ago by grt (UTC plus 2)
Modified:
3 years, 8 months ago
Reviewers:
Georges Khalil
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't uninstall Google Update for Windows Installer-driven uninstalls. GU has its own logic for dealing with uninstalls coming from Windows Installer. The call to uninstall it ends up blocking Chrome's uninstall, which is a worse user experience. GU will uninstall itself at some point down the road when it notices that all apps have been uninstalled. BUG=705420 R=georgesak@chromium.org Review-Url: https://codereview.chromium.org/2841783002 Cr-Commit-Position: refs/heads/master@{#467057} Committed: https://chromium.googlesource.com/chromium/src/+/1995a63cc353629e27d14a58e0476f864acd5c25

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/installer/setup/setup_main.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
grt (UTC plus 2)
PTAL
3 years, 8 months ago (2017-04-25 07:35:39 UTC) #3
Georges Khalil
LGTM % nit. https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setup_main.cc#newcode632 chrome/installer/setup/setup_main.cc:632: // not originate from the MSI. ...
3 years, 8 months ago (2017-04-25 15:18:24 UTC) #6
grt (UTC plus 2)
Thanks! https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setup_main.cc#newcode632 chrome/installer/setup/setup_main.cc:632: // not originate from the MSI. Gogle Update ...
3 years, 8 months ago (2017-04-25 18:01:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841783002/20001
3 years, 8 months ago (2017-04-25 18:01:41 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 18:33:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1995a63cc353629e27d14a58e047...

Powered by Google App Engine
This is Rietveld 408576698