Don't uninstall Google Update for Windows Installer-driven uninstalls.

Don't uninstall Google Update for Windows Installer-driven uninstalls.

GU has its own logic for dealing with uninstalls coming from Windows
Installer. The call to uninstall it ends up blocking Chrome's uninstall,
which is a worse user experience. GU will uninstall itself at some point
down the road when it notices that all apps have been uninstalled.

BUG=705420
R=georgesak@chromium.org

Review-Url: https://codereview.chromium.org/2841783002
Cr-Commit-Position: refs/heads/master@{#467057}
Committed: https://chromium.googlesource.com/chromium/src/+/1995a63cc353629e27d14a58e0476f864acd5c25

[grt (UTC plus 2), 2017-04-25 07:35:17]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 07:35:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-04-25 07:35:39]

PTAL

[commit-bot: I haz the power, 2017-04-25 07:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 07:58:15]

Dry run: This issue passed the CQ dry run.

[Georges Khalil, 2017-04-25 15:18:24]

LGTM % nit.

https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setu...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setu...
chrome/installer/setup/setup_main.cc:632: // not originate from the MSI. Gogle
Update has its own logic relating to
nit: s/Gogle/Google

[grt (UTC plus 2), 2017-04-25 18:01:11]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-04-25 18:01:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
georgesak@chromium.org
Link to the patchset: https://codereview.chromium.org/2841783002/#ps20001
(title: "fix typo")

[grt (UTC plus 2), 2017-04-25 18:01:31]

Thanks!

https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setu...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/2841783002/diff/1/chrome/installer/setup/setu...
chrome/installer/setup/setup_main.cc:632: // not originate from the MSI. Gogle
Update has its own logic relating to
On 2017/04/25 15:18:23, Georges Khalil (slow) wrote:
> nit: s/Gogle/Google

<facepalm>

[commit-bot: I haz the power, 2017-04-25 18:01:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 18:33:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493143271146710,
"parent_rev": "8056a52f106bc1e1451753932146b5ee3fffeaf1", "commit_rev":
"1995a63cc353629e27d14a58e0476f864acd5c25"}

[commit-bot: I haz the power, 2017-04-25 18:33:48]

Description was changed from

==========
Don't uninstall Google Update for Windows Installer-driven uninstalls.

GU has its own logic for dealing with uninstalls coming from Windows
Installer. The call to uninstall it ends up blocking Chrome's uninstall,
which is a worse user experience. GU will uninstall itself at some point
down the road when it notices that all apps have been uninstalled.

BUG=705420
R=georgesak@chromium.org
==========

to

==========
Don't uninstall Google Update for Windows Installer-driven uninstalls.

GU has its own logic for dealing with uninstalls coming from Windows
Installer. The call to uninstall it ends up blocking Chrome's uninstall,
which is a worse user experience. GU will uninstall itself at some point
down the road when it notices that all apps have been uninstalled.

BUG=705420
R=georgesak@chromium.org

Review-Url: https://codereview.chromium.org/2841783002
Cr-Commit-Position: refs/heads/master@{#467057}
Committed:
https://chromium.googlesource.com/chromium/src/+/1995a63cc353629e27d14a58e047...
==========

[commit-bot: I haz the power, 2017-04-25 18:33:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1995a63cc353629e27d14a58e047...