Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2841723002:
Use TaskScheduler instead of blocking pool in chrome_screenshot_grabber.cc. (Closed)
|
Created:
3 years, 8 months ago by fdoray Modified:
3 years, 7 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TaskScheduler instead of blocking pool in chrome_screenshot_grabber.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=jamescook@chromium.org
Review-Url: https://codereview.chromium.org/2841723002
Cr-Commit-Position: refs/heads/master@{#468381}
Committed: https://chromium.googlesource.com/chromium/src/+/e6af56f15a6aa11c41c82db2f9cb31df28f1b5e3
Patch Set 1 #Patch Set 2 : fix-build-error #
Total comments: 2
Patch Set 3 : USER_VISIBLE #Messages
Total messages: 25 (15 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bots are red
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/24 20:10:37, James Cook wrote: > bots are red Fixed. Please take another look.
https://codereview.chromium.org/2841723002/diff/20001/chrome/browser/ui/ash/c... File chrome/browser/ui/ash/chrome_screenshot_grabber.cc (right): https://codereview.chromium.org/2841723002/diff/20001/chrome/browser/ui/ash/c... chrome/browser/ui/ash/chrome_screenshot_grabber.cc:286: .WithPriority(base::TaskPriority::BACKGROUND) I think this should be USER_VISIBLE. The user is waiting for the screenshot notification to appear.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take another look https://codereview.chromium.org/2841723002/diff/20001/chrome/browser/ui/ash/c... File chrome/browser/ui/ash/chrome_screenshot_grabber.cc (right): https://codereview.chromium.org/2841723002/diff/20001/chrome/browser/ui/ash/c... chrome/browser/ui/ash/chrome_screenshot_grabber.cc:286: .WithPriority(base::TaskPriority::BACKGROUND) On 2017/04/26 20:46:44, James Cook wrote: > I think this should be USER_VISIBLE. The user is waiting for the screenshot > notification to appear. Done.
ping On 2017/04/27 13:35:31, fdoray wrote: > Please take another look > > https://codereview.chromium.org/2841723002/diff/20001/chrome/browser/ui/ash/c... > File chrome/browser/ui/ash/chrome_screenshot_grabber.cc (right): > > https://codereview.chromium.org/2841723002/diff/20001/chrome/browser/ui/ash/c... > chrome/browser/ui/ash/chrome_screenshot_grabber.cc:286: > .WithPriority(base::TaskPriority::BACKGROUND) > On 2017/04/26 20:46:44, James Cook wrote: > > I think this should be USER_VISIBLE. The user is waiting for the screenshot > > notification to appear. > > Done.
Sorry, I missed your ping via mail. LGTM. Thanks for taking care of this refactoring, btw.
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493664130372580,
"parent_rev": "38b76371cb7055257e59dc386e831ecb8c2a6306", "commit_rev":
"e6af56f15a6aa11c41c82db2f9cb31df28f1b5e3"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in chrome_screenshot_grabber.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=jamescook@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in chrome_screenshot_grabber.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2841723002 Cr-Commit-Position: refs/heads/master@{#468381} Committed: https://chromium.googlesource.com/chromium/src/+/e6af56f15a6aa11c41c82db2f9cb... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e6af56f15a6aa11c41c82db2f9cb... |
