Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issue 2841713003: [Merge to 59]Update the Windows iOS promotion so it has the same width as the bubble that appears b… (Closed)

Created:
3 years, 8 months ago by mrefaat
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to 59]Update the Windows iOS promotion so it has the same width as the bubble that appears before it. This is needed as pre-harmony because there is no fixed width for all bubbles. BUG=700759 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2815303004 Cr-Commit-Position: refs/heads/master@{#465398} (cherry picked from commit 218d4bbf6ae8e118ee2bd86a9b1761786ccd13b9) Review-Url: https://codereview.chromium.org/2841713003 Cr-Commit-Position: refs/branch-heads/3071@{#180} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/7d0a5d751fd822dc2d917283f05f9f0383c574c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M chrome/app/resources/locale_settings.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc View 5 chunks +26 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mrefaat
3 years, 8 months ago (2017-04-24 21:47:17 UTC) #4
sky
Rubber stamp LGTM
3 years, 8 months ago (2017-04-24 21:57:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841713003/1
3 years, 8 months ago (2017-04-24 21:59:24 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 22:00:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d0a5d751fd822dc2d917283f05f...

Powered by Google App Engine
This is Rietveld 408576698