Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2841683002: Use TaskScheduler instead of blocking pool in quota_policy_cookie_store.cc. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
boliu
CC:
chromium-reviews, jam, cbentzel+watch_chromium.org, darin-cc_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of blocking pool in quota_policy_cookie_store.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=boliu@chromium.org Review-Url: https://codereview.chromium.org/2841683002 Cr-Commit-Position: refs/heads/master@{#466725} Committed: https://chromium.googlesource.com/chromium/src/+/8243c7c934eeb76043b9f6fa72c2e92b263b9b07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/net/quota_policy_cookie_store.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
fdoray
3 years, 8 months ago (2017-04-24 18:46:17 UTC) #1
fdoray
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used ...
3 years, 8 months ago (2017-04-24 18:46:19 UTC) #3
boliu
lgtm
3 years, 8 months ago (2017-04-24 18:57:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841683002/1
3 years, 8 months ago (2017-04-24 18:58:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841683002/1
3 years, 8 months ago (2017-04-24 19:11:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8243c7c934eeb76043b9f6fa72c2e92b263b9b07
3 years, 8 months ago (2017-04-24 19:59:10 UTC) #14
mmenke
3 years, 7 months ago (2017-05-05 19:24:57 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2863683005/ by mmenke@chromium.org.

The reason for reverting is: This looks to have broken
RestartTest.PRE_LocalStorageClearedOnExit.  Creating a revert now so I don't
forget, but I'll CQ it Monday or Tuesday if I don't hear back about it..

Powered by Google App Engine
This is Rietveld 408576698