Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2841653002: MD Settings: Fix initialization timing of browser proxy in change-picture. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tommycli
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix initialization timing of browser proxy in change-picture. BUG=714554 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2841653002 Cr-Commit-Position: refs/heads/master@{#466710} Committed: https://chromium.googlesource.com/chromium/src/+/29374c5d9bb82e3bb15274d1e049785a1d785e68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/change_picture.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dpapad
FYI, I investigated a bit on why the existing tests did not catch this bug. ...
3 years, 8 months ago (2017-04-24 18:07:03 UTC) #5
stevenjb
Yeah, unfortunately testing timing issues is tricky at best. Thanks for investigating further, I'm happy ...
3 years, 8 months ago (2017-04-24 18:41:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841653002/1
3 years, 8 months ago (2017-04-24 19:05:11 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 19:17:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29374c5d9bb82e3bb15274d1e049...

Powered by Google App Engine
This is Rietveld 408576698